Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1035763002: Add CHECKs when updating pointers from the slots and store buffers (Closed)

Created:
5 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add CHECKs when updating pointers from the slots and store buffers We want to verify that we always overwrite heap objects with heap objects, and non-heap objects with non-heap objects BUG=chromium:452095 R=hpayer@chromium.org LOG=n Committed: https://crrev.com/58fbcfac8ae82b1241f07e1b8ea81a5973514c11 Cr-Commit-Position: refs/heads/master@{#27479}

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updatser #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M src/heap/heap.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap-inl.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 5 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
jochen (gone - plz use gerrit)
5 years, 9 months ago (2015-03-25 16:15:07 UTC) #1
jochen (gone - plz use gerrit)
ptal
5 years, 9 months ago (2015-03-25 16:37:43 UTC) #2
jochen (gone - plz use gerrit)
ptal - added comments
5 years, 9 months ago (2015-03-26 11:00:26 UTC) #3
Hannes Payer (out of office)
This CL may have performance impact. Let's check the performance bots after landing. LGTM
5 years, 9 months ago (2015-03-26 11:42:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035763002/40001
5 years, 9 months ago (2015-03-26 13:28:34 UTC) #6
jochen (gone - plz use gerrit)
i guess we can revert it after one dev channel release - either we find ...
5 years, 9 months ago (2015-03-26 13:29:03 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-26 13:29:31 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/58fbcfac8ae82b1241f07e1b8ea81a5973514c11 Cr-Commit-Position: refs/heads/master@{#27479}
5 years, 9 months ago (2015-03-26 13:29:52 UTC) #9
jochen (gone - plz use gerrit)
5 years, 8 months ago (2015-04-01 14:35:17 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1052713002/ by jochen@chromium.org.

The reason for reverting is: Got one dev-channel with this. Should be enough..

Powered by Google App Engine
This is Rietveld 408576698