src/heap/heap-inl.h - Issue 1035763002: Add CHECKs when updating pointers from the slots and store buffers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap-inl.h

Issue 1035763002: Add CHECKs when updating pointers from the slots and store buffers (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updatser Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/heap-inl.h

diff --git a/src/heap/heap-inl.h b/src/heap/heap-inl.h

index f2c593e7f87da03fe1bad50cf6fcf65c796f769a..f18d0896ac121583deea2030fb5086e38fb2debe 100644

--- a/src/heap/heap-inl.h

+++ b/src/heap/heap-inl.h

@@ -547,6 +547,8 @@ void Heap::ScavengeObject(HeapObject** p, HeapObject* object) {

if (first_word.IsForwardingAddress()) {

HeapObject* dest = first_word.ToForwardingAddress();

DCHECK(object->GetIsolate()->heap()->InFromSpace(*p));

+ // TODO(jochen): Remove again after fixing http://crbug.com/452095

+ CHECK((*p)->IsHeapObject() && dest->IsHeapObject());

*p = dest;

return;

}

« no previous file with comments | « src/heap/heap.cc ('k') | src/heap/mark-compact.cc » ('j') | no next file with comments »