Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: src/heap/heap-inl.h

Issue 1035763002: Add CHECKs when updating pointers from the slots and store buffers (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updatser Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/heap.cc ('k') | src/heap/mark-compact.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap-inl.h
diff --git a/src/heap/heap-inl.h b/src/heap/heap-inl.h
index f2c593e7f87da03fe1bad50cf6fcf65c796f769a..f18d0896ac121583deea2030fb5086e38fb2debe 100644
--- a/src/heap/heap-inl.h
+++ b/src/heap/heap-inl.h
@@ -547,6 +547,8 @@ void Heap::ScavengeObject(HeapObject** p, HeapObject* object) {
if (first_word.IsForwardingAddress()) {
HeapObject* dest = first_word.ToForwardingAddress();
DCHECK(object->GetIsolate()->heap()->InFromSpace(*p));
+ // TODO(jochen): Remove again after fixing http://crbug.com/452095
+ CHECK((*p)->IsHeapObject() && dest->IsHeapObject());
*p = dest;
return;
}
« no previous file with comments | « src/heap/heap.cc ('k') | src/heap/mark-compact.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698