Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: src/heap/heap.cc

Issue 1035763002: Add CHECKs when updating pointers from the slots and store buffers (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updatser Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/heap/heap-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api.h" 8 #include "src/api.h"
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/base/once.h" 10 #include "src/base/once.h"
(...skipping 2394 matching lines...) Expand 10 before | Expand all | Expand 10 after
2405 } 2405 }
2406 } 2406 }
2407 } 2407 }
2408 2408
2409 2409
2410 void Heap::ScavengeObjectSlow(HeapObject** p, HeapObject* object) { 2410 void Heap::ScavengeObjectSlow(HeapObject** p, HeapObject* object) {
2411 SLOW_DCHECK(object->GetIsolate()->heap()->InFromSpace(object)); 2411 SLOW_DCHECK(object->GetIsolate()->heap()->InFromSpace(object));
2412 MapWord first_word = object->map_word(); 2412 MapWord first_word = object->map_word();
2413 SLOW_DCHECK(!first_word.IsForwardingAddress()); 2413 SLOW_DCHECK(!first_word.IsForwardingAddress());
2414 Map* map = first_word.ToMap(); 2414 Map* map = first_word.ToMap();
2415 // TODO(jochen): Remove again after fixing http://crbug.com/452095
2416 CHECK((*p)->IsHeapObject() == object->IsHeapObject());
2415 map->GetHeap()->DoScavengeObject(map, p, object); 2417 map->GetHeap()->DoScavengeObject(map, p, object);
2416 } 2418 }
2417 2419
2418 2420
2419 void Heap::ConfigureInitialOldGenerationSize() { 2421 void Heap::ConfigureInitialOldGenerationSize() {
2420 if (!old_generation_size_configured_ && tracer()->SurvivalEventsRecorded()) { 2422 if (!old_generation_size_configured_ && tracer()->SurvivalEventsRecorded()) {
2421 old_generation_allocation_limit_ = 2423 old_generation_allocation_limit_ =
2422 Max(kMinimumOldGenerationAllocationLimit, 2424 Max(kMinimumOldGenerationAllocationLimit,
2423 static_cast<intptr_t>( 2425 static_cast<intptr_t>(
2424 static_cast<double>(old_generation_allocation_limit_) * 2426 static_cast<double>(old_generation_allocation_limit_) *
(...skipping 3965 matching lines...) Expand 10 before | Expand all | Expand 10 after
6390 static_cast<int>(object_sizes_last_time_[index])); 6392 static_cast<int>(object_sizes_last_time_[index]));
6391 CODE_AGE_LIST_COMPLETE(ADJUST_LAST_TIME_OBJECT_COUNT) 6393 CODE_AGE_LIST_COMPLETE(ADJUST_LAST_TIME_OBJECT_COUNT)
6392 #undef ADJUST_LAST_TIME_OBJECT_COUNT 6394 #undef ADJUST_LAST_TIME_OBJECT_COUNT
6393 6395
6394 MemCopy(object_counts_last_time_, object_counts_, sizeof(object_counts_)); 6396 MemCopy(object_counts_last_time_, object_counts_, sizeof(object_counts_));
6395 MemCopy(object_sizes_last_time_, object_sizes_, sizeof(object_sizes_)); 6397 MemCopy(object_sizes_last_time_, object_sizes_, sizeof(object_sizes_));
6396 ClearObjectStats(); 6398 ClearObjectStats();
6397 } 6399 }
6398 } 6400 }
6399 } // namespace v8::internal 6401 } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/heap/heap-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698