Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1035613003: Restore PushStackTraceAndDie for the case where we lookup starting with null (Closed)

Created:
5 years, 9 months ago by Toon Verwaest
Modified:
5 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Restore PushStackTraceAndDie for the case where we lookup starting with null BUG=chromium:434952 LOG=n Committed: https://crrev.com/755e43811d6a8f9c6906723da64cc02465f7c6ce Cr-Commit-Position: refs/heads/master@{#27439}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/lookup.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Toon Verwaest
PTAL
5 years, 9 months ago (2015-03-25 12:39:44 UTC) #2
Jakob Kummerow
LGTM with comment https://codereview.chromium.org/1035613003/diff/1/src/lookup.cc File src/lookup.cc (right): https://codereview.chromium.org/1035613003/diff/1/src/lookup.cc#newcode68 src/lookup.cc:68: isolate->PushStackTraceAndDie(magic, NULL, NULL, magic); How 'bout ...
5 years, 9 months ago (2015-03-25 12:42:43 UTC) #3
Toon Verwaest
https://codereview.chromium.org/1035613003/diff/1/src/lookup.cc File src/lookup.cc (right): https://codereview.chromium.org/1035613003/diff/1/src/lookup.cc#newcode68 src/lookup.cc:68: isolate->PushStackTraceAndDie(magic, NULL, NULL, magic); On 2015/03/25 12:42:43, Jakob wrote: ...
5 years, 9 months ago (2015-03-25 12:44:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035613003/20001
5 years, 9 months ago (2015-03-25 12:45:11 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-25 13:05:11 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 13:05:34 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/755e43811d6a8f9c6906723da64cc02465f7c6ce
Cr-Commit-Position: refs/heads/master@{#27439}

Powered by Google App Engine
This is Rietveld 408576698