Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: src/lookup.cc

Issue 1035613003: Restore PushStackTraceAndDie for the case where we lookup starting with null (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/lookup.cc
diff --git a/src/lookup.cc b/src/lookup.cc
index 929b022ed5faa5b14ff5b8d536a60e21d612d101..5a6c5da3dd54a51579be2daab08565f8391b577f 100644
--- a/src/lookup.cc
+++ b/src/lookup.cc
@@ -63,7 +63,10 @@ Handle<JSReceiver> LookupIterator::GetRoot(Handle<Object> receiver,
Isolate* isolate) {
if (receiver->IsJSReceiver()) return Handle<JSReceiver>::cast(receiver);
auto root = handle(receiver->GetRootMap(isolate)->prototype(), isolate);
- CHECK(!root->IsNull());
+ if (root->IsNull()) {
+ unsigned int magic = 0xbbbbbbbb;
+ isolate->PushStackTraceAndDie(magic, *receiver, NULL, magic);
+ }
return Handle<JSReceiver>::cast(root);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698