Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/lookup.cc

Issue 1035613003: Restore PushStackTraceAndDie for the case where we lookup starting with null (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/bootstrapper.h" 7 #include "src/bootstrapper.h"
8 #include "src/deoptimizer.h" 8 #include "src/deoptimizer.h"
9 #include "src/lookup.h" 9 #include "src/lookup.h"
10 #include "src/lookup-inl.h" 10 #include "src/lookup-inl.h"
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 holder_ = initial_holder_; 56 holder_ = initial_holder_;
57 holder_map_ = handle(holder_->map(), isolate_); 57 holder_map_ = handle(holder_->map(), isolate_);
58 Next(); 58 Next();
59 } 59 }
60 60
61 61
62 Handle<JSReceiver> LookupIterator::GetRoot(Handle<Object> receiver, 62 Handle<JSReceiver> LookupIterator::GetRoot(Handle<Object> receiver,
63 Isolate* isolate) { 63 Isolate* isolate) {
64 if (receiver->IsJSReceiver()) return Handle<JSReceiver>::cast(receiver); 64 if (receiver->IsJSReceiver()) return Handle<JSReceiver>::cast(receiver);
65 auto root = handle(receiver->GetRootMap(isolate)->prototype(), isolate); 65 auto root = handle(receiver->GetRootMap(isolate)->prototype(), isolate);
66 CHECK(!root->IsNull()); 66 if (root->IsNull()) {
67 unsigned int magic = 0xbbbbbbbb;
68 isolate->PushStackTraceAndDie(magic, *receiver, NULL, magic);
69 }
67 return Handle<JSReceiver>::cast(root); 70 return Handle<JSReceiver>::cast(root);
68 } 71 }
69 72
70 73
71 Handle<Map> LookupIterator::GetReceiverMap() const { 74 Handle<Map> LookupIterator::GetReceiverMap() const {
72 if (receiver_->IsNumber()) return isolate_->factory()->heap_number_map(); 75 if (receiver_->IsNumber()) return isolate_->factory()->heap_number_map();
73 return handle(Handle<HeapObject>::cast(receiver_)->map(), isolate_); 76 return handle(Handle<HeapObject>::cast(receiver_)->map(), isolate_);
74 } 77 }
75 78
76 79
(...skipping 309 matching lines...) Expand 10 before | Expand all | Expand 10 after
386 // Fall through. 389 // Fall through.
387 case InterceptorState::kSkipNonMasking: 390 case InterceptorState::kSkipNonMasking:
388 return true; 391 return true;
389 case InterceptorState::kProcessNonMasking: 392 case InterceptorState::kProcessNonMasking:
390 return false; 393 return false;
391 } 394 }
392 } 395 }
393 return interceptor_state_ == InterceptorState::kProcessNonMasking; 396 return interceptor_state_ == InterceptorState::kProcessNonMasking;
394 } 397 }
395 } } // namespace v8::internal 398 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698