Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1035223003: Rename content::PermissionManager to content::PermissionDispatcher. (Closed)

Created:
5 years, 9 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename content::PermissionManager to content::PermissionDispatcher. https://codereview.chromium.org/1011953003 introduces a content::PermissionManager interface which doesn't work well with the current one. BUG=437770, 430238 Committed: https://crrev.com/c6d31dbb45e964becb9b4f9c9d8bc958dc93b9b5 Cr-Commit-Position: refs/heads/master@{#322708}

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -446 lines) Patch
M content/child/blink_platform_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/blink_platform_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
A + content/child/permissions/permission_dispatcher.h View 1 3 chunks +13 lines, -13 lines 0 comments Download
A + content/child/permissions/permission_dispatcher.cc View 8 chunks +15 lines, -15 lines 0 comments Download
A + content/child/permissions/permission_dispatcher_thread_proxy.h View 3 chunks +12 lines, -12 lines 0 comments Download
A + content/child/permissions/permission_dispatcher_thread_proxy.cc View 3 chunks +22 lines, -22 lines 0 comments Download
D content/child/permissions/permission_manager.h View 1 chunk +0 lines, -87 lines 0 comments Download
D content/child/permissions/permission_manager.cc View 1 chunk +0 lines, -155 lines 0 comments Download
D content/child/permissions/permission_manager_thread_proxy.h View 1 chunk +0 lines, -54 lines 0 comments Download
D content/child/permissions/permission_manager_thread_proxy.cc View 1 chunk +0 lines, -74 lines 0 comments Download
M content/content_child.gypi View 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/render_frame_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mlamouri (slow - plz ping)
5 years, 9 months ago (2015-03-27 16:59:08 UTC) #2
johnme
lgtm
5 years, 9 months ago (2015-03-27 18:18:22 UTC) #3
Avi (use Gerrit)
stamp lgtm https://codereview.chromium.org/1035223003/diff/1/content/child/permissions/permission_dispatcher.h File content/child/permissions/permission_dispatcher.h (right): https://codereview.chromium.org/1035223003/diff/1/content/child/permissions/permission_dispatcher.h#newcode22 content/child/permissions/permission_dispatcher.h:22: // PermissionService Period at the end of ...
5 years, 9 months ago (2015-03-27 18:22:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035223003/20001
5 years, 9 months ago (2015-03-28 16:32:38 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-28 17:48:24 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-28 17:49:23 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c6d31dbb45e964becb9b4f9c9d8bc958dc93b9b5
Cr-Commit-Position: refs/heads/master@{#322708}

Powered by Google App Engine
This is Rietveld 408576698