Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1011953003: Refactor Permissions related method out of ContentBrowserClient. (Closed)

Created:
5 years, 9 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 8 months ago
CC:
asanka, benjhayden+dwatch_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, nasko+codewatch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@permission_type_enum_class
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor Permissions related method out of ContentBrowserClient. This is creating a content/public/browser/permission_manager.h interface that is hooked on the BrowserContext. It has an implementation in chrome/ android_webview/, content/shell/ and one for layout tests. BUG=437770, 430238 Committed: https://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6 Cr-Commit-Position: refs/heads/master@{#322721}

Patch Set 1 #

Patch Set 2 : some moar PermissionManager instances #

Patch Set 3 : webview/android #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : fix gn build #

Patch Set 7 : fix cros #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1083 lines, -513 lines) Patch
M android_webview/android_webview.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M android_webview/browser/aw_browser_context.h View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M android_webview/browser/aw_browser_context.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.h View 1 2 3 4 1 chunk +0 lines, -11 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 1 2 3 4 4 chunks +0 lines, -86 lines 0 comments Download
A android_webview/browser/aw_permission_manager.h View 1 2 1 chunk +48 lines, -0 lines 0 comments Download
A android_webview/browser/aw_permission_manager.cc View 1 2 1 chunk +127 lines, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 2 3 4 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 7 chunks +0 lines, -182 lines 0 comments Download
M chrome/browser/chrome_content_browser_client_unittest.cc View 2 chunks +0 lines, -69 lines 0 comments Download
A + chrome/browser/permissions/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/permissions/permission_context.h View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
A chrome/browser/permissions/permission_context.cc View 1 2 1 chunk +69 lines, -0 lines 0 comments Download
A chrome/browser/permissions/permission_manager.h View 1 chunk +54 lines, -0 lines 0 comments Download
A chrome/browser/permissions/permission_manager.cc View 1 1 chunk +165 lines, -0 lines 0 comments Download
A chrome/browser/permissions/permission_manager_factory.h View 1 chunk +38 lines, -0 lines 0 comments Download
A chrome/browser/permissions/permission_manager_factory.cc View 1 chunk +45 lines, -0 lines 0 comments Download
A chrome/browser/permissions/permission_manager_unittest.cc View 1 2 3 4 5 6 1 chunk +95 lines, -0 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/testing_profile.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/download/download_manager_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 2 chunks +9 lines, -4 lines 0 comments Download
M content/browser/media/cdm/browser_cdm_manager.cc View 1 2 3 2 chunks +12 lines, -5 lines 0 comments Download
M content/browser/permissions/permission_service_impl.cc View 4 chunks +32 lines, -9 lines 0 comments Download
M content/content_shell.gypi View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M content/public/browser/browser_context.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 2 3 4 1 chunk +0 lines, -29 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 chunk +0 lines, -18 lines 0 comments Download
A content/public/browser/permission_manager.h View 1 2 3 1 chunk +50 lines, -0 lines 0 comments Download
M content/public/test/test_browser_context.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/test_browser_context.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/shell/BUILD.gn View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_browser_context.h View 1 3 chunks +3 lines, -0 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_browser_context.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_content_browser_client.h View 1 2 chunks +0 lines, -8 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_content_browser_client.cc View 1 3 chunks +0 lines, -41 lines 0 comments Download
A content/shell/browser/layout_test/layout_test_permission_manager.h View 1 1 chunk +34 lines, -0 lines 0 comments Download
A content/shell/browser/layout_test/layout_test_permission_manager.cc View 1 2 3 1 chunk +72 lines, -0 lines 0 comments Download
M content/shell/browser/shell_browser_context.h View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M content/shell/browser/shell_browser_context.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 1 2 chunks +0 lines, -20 lines 0 comments Download
A content/shell/browser/shell_permission_manager.h View 1 1 chunk +47 lines, -0 lines 0 comments Download
A content/shell/browser/shell_permission_manager.cc View 1 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
mlamouri (slow - plz ping)
jochen@, could you review the changes to these files: chrome/browser/BUILD.gn chrome/browser/profiles/off_the_record_profile_impl.cc chrome/browser/profiles/off_the_record_profile_impl.h chrome/browser/profiles/profile_impl.cc chrome/browser/profiles/profile_impl.h chrome/browser/ui/app_list/test/fake_profile.cc ...
5 years, 9 months ago (2015-03-25 18:52:51 UTC) #2
mlamouri (slow - plz ping)
TL;DR: jochen@ => content/ and chrome/ torne@ => android_webview/ ;)
5 years, 9 months ago (2015-03-25 18:53:40 UTC) #3
Torne
android_webview LGTM
5 years, 9 months ago (2015-03-26 10:42:51 UTC) #4
mlamouri (slow - plz ping)
+bauerb@
5 years, 9 months ago (2015-03-26 10:42:53 UTC) #6
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-26 15:40:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011953003/120001
5 years, 8 months ago (2015-03-29 13:54:45 UTC) #10
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 8 months ago (2015-03-29 14:51:16 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-03-29 14:52:11 UTC) #12
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6
Cr-Commit-Position: refs/heads/master@{#322721}

Powered by Google App Engine
This is Rietveld 408576698