Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1034593002: Fix WindowAndroid leak in Android WebView (Closed)

Created:
5 years, 9 months ago by boliu
Modified:
5 years, 9 months ago
Reviewers:
Ted C, no sievers, Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix WindowAndroid leak in Android WebView WebView creates a WindowAndroid class per AwContents, but never calls destroy on it, so the native WindowAndroid leaks. Do this in CleanupReference of AwContents. Also make native WindowAndroid hold a strong reference, so removes the requirement to null check the ref, which are mostly missing anyway. Notes: * This adds the requirement that WindowAndroid cannot hold strong ref that would prevent AwContents/ContentViewCore from being gc-ed, which currently is the case. * This does not address the issue that WindowAndroid should be per-activity, not per ContentViewCore. BUG=469803 Committed: https://crrev.com/f1c913e8c18946c07d1a64f118b2d36e1bbe170f Cr-Commit-Position: refs/heads/master@{#322159}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 3 chunks +10 lines, -5 lines 0 comments Download
M ui/android/window_android.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/android/window_android.cc View 3 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
boliu
ptal feel free to add anyone else that should be notified..
5 years, 9 months ago (2015-03-24 21:48:07 UTC) #2
Ted C
lgtm, this change is fine for chrome for android.
5 years, 9 months ago (2015-03-24 22:17:31 UTC) #3
no sievers
lgtm
5 years, 9 months ago (2015-03-24 23:05:39 UTC) #4
Torne
lgtm
5 years, 9 months ago (2015-03-25 10:12:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034593002/1
5 years, 9 months ago (2015-03-25 14:25:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 14:49:17 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 14:49:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1c913e8c18946c07d1a64f118b2d36e1bbe170f
Cr-Commit-Position: refs/heads/master@{#322159}

Powered by Google App Engine
This is Rietveld 408576698