Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: ui/android/window_android.cc

Issue 1034593002: Fix WindowAndroid leak in Android WebView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/android/window_android.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/android/window_android.cc
diff --git a/ui/android/window_android.cc b/ui/android/window_android.cc
index cb163ff817da316f5f01edc92c2c256068c07a88..d8623a5cb51c93c56db979470a9c87177ab78335 100644
--- a/ui/android/window_android.cc
+++ b/ui/android/window_android.cc
@@ -17,8 +17,8 @@ namespace ui {
using base::android::AttachCurrentThread;
using base::android::ScopedJavaLocalRef;
-WindowAndroid::WindowAndroid(JNIEnv* env, jobject obj)
- : weak_java_window_(env, obj), compositor_(NULL) {
+WindowAndroid::WindowAndroid(JNIEnv* env, jobject obj) : compositor_(NULL) {
+ java_window_.Reset(env, obj);
}
void WindowAndroid::Destroy(JNIEnv* env, jobject obj) {
@@ -26,7 +26,7 @@ void WindowAndroid::Destroy(JNIEnv* env, jobject obj) {
}
ScopedJavaLocalRef<jobject> WindowAndroid::GetJavaObject() {
- return weak_java_window_.get(AttachCurrentThread());
+ return base::android::ScopedJavaLocalRef<jobject>(java_window_);
}
bool WindowAndroid::RegisterWindowAndroid(JNIEnv* env) {
@@ -72,10 +72,7 @@ void WindowAndroid::DetachCompositor() {
void WindowAndroid::RequestVSyncUpdate() {
JNIEnv* env = AttachCurrentThread();
- ScopedJavaLocalRef<jobject> obj = GetJavaObject();
- if (obj.is_null())
- return;
- Java_WindowAndroid_requestVSyncUpdate(env, obj.obj());
+ Java_WindowAndroid_requestVSyncUpdate(env, GetJavaObject().obj());
}
void WindowAndroid::SetNeedsAnimate() {
« no previous file with comments | « ui/android/window_android.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698