ui/android/window_android.h - Issue 1034593002: Fix WindowAndroid leak in Android WebView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/android/window_android.h

Issue 1034593002: Fix WindowAndroid leak in Android WebView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/android/window_android.h

diff --git a/ui/android/window_android.h b/ui/android/window_android.h

index cb201cd9e45b0e48a3de8782b9f7fad930973e4c..f464a11bdfbedc9c4bdcc8f9828fc84a92ec1c8c 100644

--- a/ui/android/window_android.h

+++ b/ui/android/window_android.h

@@ -63,7 +63,7 @@ class UI_ANDROID_EXPORT WindowAndroid {

private:

~WindowAndroid();

- JavaObjectWeakGlobalRef weak_java_window_;

+ base::android::ScopedJavaGlobalRef<jobject> java_window_;

gfx::Vector2dF content_offset_;

WindowAndroidCompositor* compositor_;