Fire AX notifications on list box options.

Source/core/html/HTMLOptionElement.cpp

Index: Source/core/html/HTMLOptionElement.cpp
diff --git a/Source/core/html/HTMLOptionElement.cpp b/Source/core/html/HTMLOptionElement.cpp
index e571fc594e9b3e54e6d1a9718648ef63188a2381..cd12ffb4c57c29fd44de4109ee5fe609e97caa14 100644
--- a/Source/core/html/HTMLOptionElement.cpp
+++ b/Source/core/html/HTMLOptionElement.cpp
@@ -29,6 +29,7 @@
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/HTMLNames.h"
+#include "core/dom/AXObjectCache.h"
 #include "core/dom/Document.h"
 #include "core/dom/NodeLayoutStyle.h"
 #include "core/dom/NodeTraversal.h"
@@ -264,8 +265,16 @@ void HTMLOptionElement::setSelectedState(bool selected)
     m_isSelected = selected;
     pseudoStateChanged(CSSSelector::PseudoChecked);
 
-    if (HTMLSelectElement* select = ownerSelectElement())
+    if (HTMLSelectElement* select = ownerSelectElement()) {
         select->invalidateSelectedItems();
+
+        if (AXObjectCache* cache = document().existingAXObjectCache()) {
+            if (!select->layoutObject() || select->layoutObject()->isListBox()) {

[je_julie(Not used), 2015/03/31 03:51:04]

((there is no layoutObject) or (layoutObject is ListBox))
Do you intent to check whether it has no layoutobject and the layoutobject is
listbox if it has layoutobject?

[dmazzoni, 2015/03/31 06:57:37]

I want to fire these notifications under two circumstances:
* If it does have a layout object (the most common case), I only want to fire
these notifications if it's a list box (and not a menu list).
* If it does not have a layout object (rare, maybe only inside of a <canvas>
subtree), I want to fire these notifications anyway, because it won't be
rendered on screen but will act to the user kind of like a listbox.

I added a comment to clarify this.

+                cache->listboxOptionStateChanged(this);
+                cache->listboxSelectedChildrenChanged(select);
+            }
+        }
+    }
 }
 
 void HTMLOptionElement::childrenChanged(const ChildrenChange& change)