Source/core/html/HTMLSelectElement.cpp - Issue 1034493005: Fire AX notifications on list box options.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLSelectElement.cpp

Issue 1034493005: Fire AX notifications on list box options. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@menu_list_more

Patch Set: Rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/HTMLOptionElement.cpp ('K') | « Source/core/html/HTMLOptionElement.cpp ('k') | Source/modules/accessibility/AXListBox.h » ('j') | Source/modules/accessibility/AXListBox.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLSelectElement.cpp

diff --git a/Source/core/html/HTMLSelectElement.cpp b/Source/core/html/HTMLSelectElement.cpp

index f820c5413f8ab429e581f0afcf92d01e2c143671..3b826df79ec5a3f23343764ad92fab5702e61b41 100644

--- a/Source/core/html/HTMLSelectElement.cpp

+++ b/Source/core/html/HTMLSelectElement.cpp

@@ -730,7 +730,7 @@ void HTMLSelectElement::scrollToSelection()

return;

scrollToIndex(activeSelectionEndListIndex());

if (AXObjectCache* cache = document().existingAXObjectCache())

- cache->selectedChildrenChanged(this);

+ cache->listboxActiveIndexChanged(this);

}

void HTMLSelectElement::setOptionsChangedOnRenderer()

@@ -970,9 +970,6 @@ void HTMLSelectElement::selectOption(int optionIndex, SelectOptionFlags flags)

if (LayoutObject* renderer = this->layoutObject()) {

if (usesMenuList()) {

toLayoutMenuList(renderer)->didSetSelectedIndex(listIndex);

- } else if (renderer->isListBox()) {

- if (AXObjectCache* cache = document().existingAXObjectCache())

- cache->selectedChildrenChanged(this);

}