Fire AX notifications on list box options.

Source/core/html/HTMLOptionElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2004, 2005, 2006, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2011 Motorola Mobility, Inc.  All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 11 matching lines @@
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  *
  */
 
 #include "config.h"
 #include "core/html/HTMLOptionElement.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/HTMLNames.h"
+#include "core/dom/AXObjectCache.h"
 #include "core/dom/Document.h"
 #include "core/dom/NodeLayoutStyle.h"
 #include "core/dom/NodeTraversal.h"
 #include "core/dom/ScriptLoader.h"
 #include "core/dom/Text.h"
 #include "core/dom/shadow/ShadowRoot.h"
 #include "core/html/HTMLDataListElement.h"
 #include "core/html/HTMLOptGroupElement.h"
 #include "core/html/HTMLSelectElement.h"
 #include "core/html/parser/HTMLParserIdioms.h"
@@ skipping 215 matching lines @@
 }
 
 void HTMLOptionElement::setSelectedState(bool selected)
 {
     if (m_isSelected == selected)
         return;
 
     m_isSelected = selected;
     pseudoStateChanged(CSSSelector::PseudoChecked);
 
-    if (HTMLSelectElement* select = ownerSelectElement())
+    if (HTMLSelectElement* select = ownerSelectElement()) {
         select->invalidateSelectedItems();
+
+        if (AXObjectCache* cache = document().existingAXObjectCache()) {
+            if (!select->layoutObject() || select->layoutObject()->isListBox()) {

[je_julie(Not used), 2015/03/31 03:51:04]

((there is no layoutObject) or (layoutObject is ListBox))
Do you intent to check whether it has no layoutobject and the layoutobject is
listbox if it has layoutobject?

[dmazzoni, 2015/03/31 06:57:37]

I want to fire these notifications under two circumstances:
* If it does have a layout object (the most common case), I only want to fire
these notifications if it's a list box (and not a menu list).
* If it does not have a layout object (rare, maybe only inside of a <canvas>
subtree), I want to fire these notifications anyway, because it won't be
rendered on screen but will act to the user kind of like a listbox.

I added a comment to clarify this.

+                cache->listboxOptionStateChanged(this);
+                cache->listboxSelectedChildrenChanged(select);
+            }
+        }
+    }
 }
 
 void HTMLOptionElement::childrenChanged(const ChildrenChange& change)
 {
     if (HTMLDataListElement* dataList = ownerDataListElement())
         dataList->optionElementChildrenChanged();
     else if (HTMLSelectElement* select = ownerSelectElement())
         select->optionElementChildrenChanged();
     updateLabel();
     HTMLElement::childrenChanged(change);
@@ skipping 146 matching lines @@
         ASSERT(parent);
         if (isHTMLOptGroupElement(*parent)) {
             const LayoutStyle* parentStyle = parent->layoutStyle() ? parent->layoutStyle() : parent->computedStyle();
             return !parentStyle || parentStyle->display() == NONE;
         }
     }
     return m_style->display() == NONE;
 }
 
 } // namespace blink