Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 1034453002: [bindings] Remove custom binding usage from XMLHttpRequest.open() (Closed)

Created:
5 years, 9 months ago by vivekg_samsung
Modified:
5 years, 9 months ago
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, Inactive, tyoshino+watch_chromium.org, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Remove custom binding usage from XMLHttpRequest.open() Modified the XHR.open(...) signatures to match the auto generated code and redirected these using the KURL to real open method. BUG=345519 R=haraken@chromium.org, yhirano@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192466

Patch Set 1 #

Total comments: 1

Patch Set 2 : AtomicString => String #

Total comments: 3

Patch Set 3 : isEmpty => isNull #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -58 lines) Patch
M Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp View 1 chunk +0 lines, -46 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.h View 1 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 2 2 chunks +16 lines, -8 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.idl View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (7 generated)
vivekg
PTAL, thanks.
5 years, 9 months ago (2015-03-24 08:39:09 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-24 08:47:56 UTC) #3
yhirano
https://codereview.chromium.org/1034453002/diff/1/Source/core/xmlhttprequest/XMLHttpRequest.h File Source/core/xmlhttprequest/XMLHttpRequest.h (right): https://codereview.chromium.org/1034453002/diff/1/Source/core/xmlhttprequest/XMLHttpRequest.h#newcode115 Source/core/xmlhttprequest/XMLHttpRequest.h:115: void open(const AtomicString& method, const AtomicString& url, ExceptionState&); Why ...
5 years, 9 months ago (2015-03-24 09:10:47 UTC) #4
vivekg
On 2015/03/24 at 09:10:47, yhirano wrote: > https://codereview.chromium.org/1034453002/diff/1/Source/core/xmlhttprequest/XMLHttpRequest.h > File Source/core/xmlhttprequest/XMLHttpRequest.h (right): > > https://codereview.chromium.org/1034453002/diff/1/Source/core/xmlhttprequest/XMLHttpRequest.h#newcode115 ...
5 years, 9 months ago (2015-03-24 09:26:23 UTC) #6
yhirano
https://codereview.chromium.org/1034453002/diff/40002/Source/core/xmlhttprequest/XMLHttpRequest.idl File Source/core/xmlhttprequest/XMLHttpRequest.idl (right): https://codereview.chromium.org/1034453002/diff/40002/Source/core/xmlhttprequest/XMLHttpRequest.idl#newcode61 Source/core/xmlhttprequest/XMLHttpRequest.idl:61: [RaisesException] void open(DOMString method, DOMString url, optional boolean async, ...
5 years, 9 months ago (2015-03-24 10:49:39 UTC) #9
vivekg
On 2015/03/24 at 10:49:39, yhirano wrote: > https://codereview.chromium.org/1034453002/diff/40002/Source/core/xmlhttprequest/XMLHttpRequest.idl > File Source/core/xmlhttprequest/XMLHttpRequest.idl (right): > > https://codereview.chromium.org/1034453002/diff/40002/Source/core/xmlhttprequest/XMLHttpRequest.idl#newcode61 ...
5 years, 9 months ago (2015-03-24 10:53:24 UTC) #10
Jens Widell
https://codereview.chromium.org/1034453002/diff/40002/Source/core/xmlhttprequest/XMLHttpRequest.idl File Source/core/xmlhttprequest/XMLHttpRequest.idl (right): https://codereview.chromium.org/1034453002/diff/40002/Source/core/xmlhttprequest/XMLHttpRequest.idl#newcode61 Source/core/xmlhttprequest/XMLHttpRequest.idl:61: [RaisesException] void open(DOMString method, DOMString url, optional boolean async, ...
5 years, 9 months ago (2015-03-24 13:44:26 UTC) #12
yhirano
On 2015/03/24 13:44:26, Jens Widell wrote: > https://codereview.chromium.org/1034453002/diff/40002/Source/core/xmlhttprequest/XMLHttpRequest.idl > File Source/core/xmlhttprequest/XMLHttpRequest.idl (right): > > https://codereview.chromium.org/1034453002/diff/40002/Source/core/xmlhttprequest/XMLHttpRequest.idl#newcode61 ...
5 years, 9 months ago (2015-03-24 14:04:14 UTC) #13
yhirano
https://codereview.chromium.org/1034453002/diff/40002/Source/core/xmlhttprequest/XMLHttpRequest.cpp File Source/core/xmlhttprequest/XMLHttpRequest.cpp (right): https://codereview.chromium.org/1034453002/diff/40002/Source/core/xmlhttprequest/XMLHttpRequest.cpp#newcode774 Source/core/xmlhttprequest/XMLHttpRequest.cpp:774: if (!user.isEmpty()) Can you tell me why you use ...
5 years, 9 months ago (2015-03-24 14:07:22 UTC) #14
vivekg
On 2015/03/24 at 14:07:22, yhirano wrote: > https://codereview.chromium.org/1034453002/diff/40002/Source/core/xmlhttprequest/XMLHttpRequest.cpp > File Source/core/xmlhttprequest/XMLHttpRequest.cpp (right): > > https://codereview.chromium.org/1034453002/diff/40002/Source/core/xmlhttprequest/XMLHttpRequest.cpp#newcode774 ...
5 years, 9 months ago (2015-03-24 14:54:00 UTC) #15
yhirano
lgtm
5 years, 9 months ago (2015-03-24 16:12:29 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034453002/90001
5 years, 9 months ago (2015-03-24 17:41:22 UTC) #19
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 19:52:43 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:90001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192466

Powered by Google App Engine
This is Rietveld 408576698