Source/core/xmlhttprequest/XMLHttpRequest.idl - Issue 1034453002: [bindings] Remove custom binding usage from XMLHttpRequest.open()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/xmlhttprequest/XMLHttpRequest.idl

Issue 1034453002: [bindings] Remove custom binding usage from XMLHttpRequest.open() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: isEmpty => isNull Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/xmlhttprequest/XMLHttpRequest.idl

diff --git a/Source/core/xmlhttprequest/XMLHttpRequest.idl b/Source/core/xmlhttprequest/XMLHttpRequest.idl

index 5f1e0f41e25a1e21c99e5cbf0de8ce8545cfeebc..a81de73379cf71ca0289d8ab38aae83656434bc3 100644

--- a/Source/core/xmlhttprequest/XMLHttpRequest.idl

+++ b/Source/core/xmlhttprequest/XMLHttpRequest.idl

@@ -58,7 +58,7 @@ enum XMLHttpRequestResponseType {

[RaisesException=Setter] attribute boolean withCredentials;

- [Custom, RaisesException] void open(DOMString method, DOMString url, optional boolean async, optional DOMString user, optional DOMString password);

+ [RaisesException] void open(DOMString method, DOMString url, optional boolean async, [TreatUndefinedAs=NullString] optional DOMString? user, [TreatUndefinedAs=NullString] optional DOMString? password);

[RaisesException] void setRequestHeader(DOMString header, DOMString value);

« no previous file with comments | « Source/core/xmlhttprequest/XMLHttpRequest.cpp ('k') | no next file » | no next file with comments »