Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: Source/core/xmlhttprequest/XMLHttpRequest.idl

Issue 1034453002: [bindings] Remove custom binding usage from XMLHttpRequest.open() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: AtomicString => String Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2008, 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 const unsigned short OPENED = 1; 51 const unsigned short OPENED = 1;
52 const unsigned short HEADERS_RECEIVED = 2; 52 const unsigned short HEADERS_RECEIVED = 2;
53 const unsigned short LOADING = 3; 53 const unsigned short LOADING = 3;
54 const unsigned short DONE = 4; 54 const unsigned short DONE = 4;
55 55
56 [RaisesException=Setter] attribute unsigned long timeout; 56 [RaisesException=Setter] attribute unsigned long timeout;
57 readonly attribute unsigned short readyState; 57 readonly attribute unsigned short readyState;
58 58
59 [RaisesException=Setter] attribute boolean withCredentials; 59 [RaisesException=Setter] attribute boolean withCredentials;
60 60
61 [Custom, RaisesException] void open(DOMString method, DOMString url, optiona l boolean async, optional DOMString user, optional DOMString password); 61 [RaisesException] void open(DOMString method, DOMString url, optional boolea n async, [TreatUndefinedAs=NullString] optional DOMString? user, [TreatUndefined As=NullString] optional DOMString? password);
yhirano 2015/03/24 10:49:39 TreatNullAs=NullString needed? Can we have tests?
Jens Widell 2015/03/24 13:44:26 'DOMString?', used here, has the same effect as [T
62 62
63 [RaisesException] void setRequestHeader(DOMString header, DOMString value); 63 [RaisesException] void setRequestHeader(DOMString header, DOMString value);
64 64
65 [RaisesException] void send(optional (ArrayBuffer or ArrayBufferView or Blob or Document or DOMString or FormData)? data); 65 [RaisesException] void send(optional (ArrayBuffer or ArrayBufferView or Blob or Document or DOMString or FormData)? data);
66 66
67 void abort(); 67 void abort();
68 68
69 readonly attribute XMLHttpRequestUpload upload; 69 readonly attribute XMLHttpRequestUpload upload;
70 70
71 // response 71 // response
72 [TreatReturnedNullStringAs=Undefined] DOMString getAllResponseHeaders(); 72 [TreatReturnedNullStringAs=Undefined] DOMString getAllResponseHeaders();
73 DOMString? getResponseHeader(DOMString header); 73 DOMString? getResponseHeader(DOMString header);
74 [Custom=Getter, RaisesException=Getter] readonly attribute DOMString? respon seText; 74 [Custom=Getter, RaisesException=Getter] readonly attribute DOMString? respon seText;
75 [RaisesException=Getter] readonly attribute Document responseXML; 75 [RaisesException=Getter] readonly attribute Document responseXML;
76 76
77 [RaisesException=Setter] attribute XMLHttpRequestResponseType responseType; 77 [RaisesException=Setter] attribute XMLHttpRequestResponseType responseType;
78 [Custom=Getter, RaisesException=Getter] readonly attribute object response; 78 [Custom=Getter, RaisesException=Getter] readonly attribute object response;
79 readonly attribute DOMString responseURL; 79 readonly attribute DOMString responseURL;
80 80
81 readonly attribute unsigned short status; 81 readonly attribute unsigned short status;
82 readonly attribute DOMString statusText; 82 readonly attribute DOMString statusText;
83 83
84 // Extension 84 // Extension
85 [RaisesException] void overrideMimeType(DOMString override); 85 [RaisesException] void overrideMimeType(DOMString override);
86 }; 86 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698