Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1132)

Issue 1034403002: Allow more scavenges in idle notification by increasing the new space limit distance. (Closed)

Created:
5 years, 8 months ago by Hannes Payer (out of office)
Modified:
5 years, 8 months ago
Reviewers:
ulan, Erik Corry, rmcilroy
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allow more scavenges in idle notification by increasing the new space limit distance. BUG=chromium:468554 LOG=n Committed: https://crrev.com/bffde6f4ab9ae40e78f4b57d8e0909180b9b61a4 Cr-Commit-Position: refs/heads/master@{#27517}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M src/heap/gc-idle-time-handler.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap/gc-idle-time-handler.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download
M test/unittests/heap/gc-idle-time-handler-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Hannes Payer (out of office)
5 years, 8 months ago (2015-03-27 12:43:55 UTC) #2
Erik Corry
5 years, 8 months ago (2015-03-27 14:51:51 UTC) #4
Erik Corry
lgtm
5 years, 8 months ago (2015-03-27 14:52:00 UTC) #5
rmcilroy
https://codereview.chromium.org/1034403002/diff/1/src/heap/gc-idle-time-handler.cc File src/heap/gc-idle-time-handler.cc (right): https://codereview.chromium.org/1034403002/diff/1/src/heap/gc-idle-time-handler.cc#newcode136 src/heap/gc-idle-time-handler.cc:136: kMaxScheduledIdleTime * 2; Pull out 'kMaxScheduledIdleTime * 2' as ...
5 years, 8 months ago (2015-03-27 15:07:50 UTC) #6
Hannes Payer (out of office)
https://codereview.chromium.org/1034403002/diff/1/src/heap/gc-idle-time-handler.cc File src/heap/gc-idle-time-handler.cc (right): https://codereview.chromium.org/1034403002/diff/1/src/heap/gc-idle-time-handler.cc#newcode136 src/heap/gc-idle-time-handler.cc:136: kMaxScheduledIdleTime * 2; On 2015/03/27 15:07:50, rmcilroy wrote: > ...
5 years, 8 months ago (2015-03-30 11:07:15 UTC) #7
rmcilroy
On 2015/03/30 11:07:15, Hannes Payer wrote: > https://codereview.chromium.org/1034403002/diff/1/src/heap/gc-idle-time-handler.cc > File src/heap/gc-idle-time-handler.cc (right): > > https://codereview.chromium.org/1034403002/diff/1/src/heap/gc-idle-time-handler.cc#newcode136 ...
5 years, 8 months ago (2015-03-30 11:16:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034403002/20001
5 years, 8 months ago (2015-03-30 11:17:38 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-03-30 11:39:54 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 11:40:23 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bffde6f4ab9ae40e78f4b57d8e0909180b9b61a4
Cr-Commit-Position: refs/heads/master@{#27517}

Powered by Google App Engine
This is Rietveld 408576698