chrome/browser/devtools/device/usb/android_usb_device.cc - Issue 1034333002: Check USB device path access when prompting users to select a device.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/usb/android_usb_device.cc

Issue 1034333002: Check USB device path access when prompting users to select a device. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Have MockPermissionBrokerClient extend FakePermissionBrokerClient to avoid adding mocks for unrelat… Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/device/usb/android_usb_browsertest.cc ('k') | chrome/browser/extensions/api/device_permissions_manager_unittest.cc » ('j') | chromeos/network/firewall_hole_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/device/usb/android_usb_device.cc

diff --git a/chrome/browser/devtools/device/usb/android_usb_device.cc b/chrome/browser/devtools/device/usb/android_usb_device.cc

index 4ced939f631d8a2724ec128f8c07e3f57e386881..9e5d700e885f5df9e14a128a9a87be722b508721 100644

--- a/chrome/browser/devtools/device/usb/android_usb_device.cc

+++ b/chrome/browser/devtools/device/usb/android_usb_device.cc

@@ -265,14 +265,9 @@ static void EnumerateOnFileThread(

continue;

}

- // Request permission on Chrome OS.

-#if defined(OS_CHROMEOS)

device->RequestUsbAccess(

j, base::Bind(&OpenAndroidDeviceOnFileThread, devices, rsa_key,

barrier, device, j));

-#else

- OpenAndroidDeviceOnFileThread(devices, rsa_key, barrier, device, j, true);

-#endif // defined(OS_CHROMEOS)

has_android_interface = true;

break;