Check USB device path access when prompting users to select a device.

chromeos/network/firewall_hole_unittest.cc

Index: chromeos/network/firewall_hole_unittest.cc
diff --git a/chromeos/network/firewall_hole_unittest.cc b/chromeos/network/firewall_hole_unittest.cc
index ea5f5ec300ce58a00e9e01470564059e3d9e41af..fb182053f55111e524b0590024f5b91bed679abe 100644
--- a/chromeos/network/firewall_hole_unittest.cc
+++ b/chromeos/network/firewall_hole_unittest.cc
@@ -23,16 +23,12 @@ ACTION_TEMPLATE(InvokeCallback,
   ::std::tr1::get<k>(args).Run(p1);
 }
 
-class MockPermissionsBrokerClient : public chromeos::PermissionBrokerClient {
+class MockPermissionsBrokerClient
+    : public chromeos::FakePermissionBrokerClient {

[pneubeck (no reviews), 2015/04/07 07:57:38]

nothing of that fake is actually used. If anything is used of it in the future,
that might be by accident.

Please instead keep the old base class and implement the Init(),
RequestPathAccess(), and the new CheckPathAccess() with a CHECK(false) /
ASSERT_TRUE(false).
(the include of fake_permission... above is wrong then)

[Reilly Grant (use Gerrit), 2015/04/07 20:12:10]

I've moved MockPermissionBrokerClient into its own header and removed the
inheritance relationship to continue to avoid updating this file for unrelated
changes to the PermissionBrokerClient interface.

  public:
   MockPermissionsBrokerClient() {}
   ~MockPermissionsBrokerClient() override {}
 
-  MOCK_METHOD1(Init, void(dbus::Bus* bus));
-  MOCK_METHOD3(RequestPathAccess,
-               void(const std::string& path,
-                    int interface_id,
-                    const ResultCallback& callback));
   MOCK_METHOD4(RequestTcpPortAccess,
                void(uint16 port,
                     const std::string& interface,