chrome/browser/devtools/device/usb/android_usb_browsertest.cc - Issue 1034333002: Check USB device path access when prompting users to select a device.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/usb/android_usb_browsertest.cc

Issue 1034333002: Check USB device path access when prompting users to select a device. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Have MockPermissionBrokerClient extend FakePermissionBrokerClient to avoid adding mocks for unrelat… Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/devtools/device/usb/android_usb_browsertest.cc

diff --git a/chrome/browser/devtools/device/usb/android_usb_browsertest.cc b/chrome/browser/devtools/device/usb/android_usb_browsertest.cc

index 0c96628de1bbdac2731522c9b41a90d8089fab95..c7f99ed6dccf78c937fd6e3dde81d8567d3f7723 100644

--- a/chrome/browser/devtools/device/usb/android_usb_browsertest.cc

+++ b/chrome/browser/devtools/device/usb/android_usb_browsertest.cc

@@ -433,18 +433,6 @@ class MockUsbDevice : public UsbDevice {

return true;

}

-#if defined(OS_CHROMEOS)

- // On ChromeOS, if an interface of a claimed device is not claimed, the

- // permission broker can change the owner of the device so that the unclaimed

- // interfaces can be used. If this argument is missing, permission broker will

- // not be used and this method fails if the device is claimed.

- virtual void RequestUsbAccess(

- int interface_id,

- const base::Callback<void(bool success)>& callback) override {

- callback.Run(true);

- }

-#endif // OS_CHROMEOS

std::set<int> claimed_interfaces_;

protected:

« no previous file with comments | « DEPS ('k') | chrome/browser/devtools/device/usb/android_usb_device.cc » ('j') | chromeos/network/firewall_hole_unittest.cc » ('J')