Check USB device path access when prompting users to select a device.

Check USB device path access when prompting users to select a device.

Use the permission_broker's new CheckPathAccess method to filter
devices presented to the user by whether or not Chrome will be able to
open them later.

By having FakePermissionBrokerClient and the base UsbDevice class always
return true to access requests a number of #if defined(OS_CHROMEOS)
checks can be removed.

//third_party/cros_system_api is rolled from 95c486f3 to aea83430 to
pull in the new kCheckPathAccess definition in service_constants.h.

BUG=441526
Committed: https://crrev.com/556a9e9fddcc48e9b9650f2ac4a413ce4705efdf
Cr-Commit-Position: refs/heads/master@{#324139}

[Reilly Grant (use Gerrit), 2015-03-26 23:45:06]

reillyg@chromium.org changed reviewers:
+ rockot@chromium.org

[Reilly Grant (use Gerrit), 2015-03-26 23:45:06]

Please take a look.

[Ken Rockot(use gerrit already), 2015-03-28 19:16:01]

lgtm

[Reilly Grant (use Gerrit), 2015-03-31 19:42:41]

reillyg@chromium.org changed reviewers:
+ dgozman@chromium.org, hashimoto@chromium.org, pneubeck@chromium.org

[Reilly Grant (use Gerrit), 2015-03-31 19:45:05]

dgozman@, please take a look at the changes in
chrome/browser/devtools/device/usb.

pneubeck@, please take a look at the change to
chromeos/network/firewall_hole_unittest.cc.

hashimoto@, please take a look at the changes in chromeos/dbus.

[hashimoto, 2015-04-01 04:48:02]

chromeos/dbus/ lgtm

[dgozman, 2015-04-01 13:48:04]

chrome/browser/devtools lgtm, but can we please wait until branch point before
landing this? This area does not have particularly good test coverage,
especially on Windows.

[Reilly Grant (use Gerrit), 2015-04-01 15:57:42]

On 2015/04/01 at 13:48:04, dgozman wrote:
> chrome/browser/devtools lgtm, but can we please wait until branch point before
landing this? This area does not have particularly good test coverage,
especially on Windows.

I would rather not wait because I have a developer waiting on this for M-43.
This change only effects Chrome OS and only the
chrome.usb.getUserSelectedDevices API but I'll bang on DevTools on Windows extra
hard just in case.

[Reilly Grant (use Gerrit), 2015-04-03 18:07:32]

reillyg@chromium.org changed reviewers:
+ stevenjb@chromium.org
- pneubeck@chromium.org

[Reilly Grant (use Gerrit), 2015-04-03 18:08:05]

stevenjb@, please take a look at the minor change in
chromeos/network/firewall_hole_unittest.cc.

[pneubeck (no reviews), 2015-04-07 07:57:38]

pneubeck@chromium.org changed reviewers:
+ pneubeck@chromium.org

[pneubeck (no reviews), 2015-04-07 07:57:38]

ptal at my comment. As it's not a big deal, giving a lgtm already.

https://codereview.chromium.org/1034333002/diff/60001/chromeos/network/firewa...
File chromeos/network/firewall_hole_unittest.cc (right):

https://codereview.chromium.org/1034333002/diff/60001/chromeos/network/firewa...
chromeos/network/firewall_hole_unittest.cc:27: : public
chromeos::FakePermissionBrokerClient {
nothing of that fake is actually used. If anything is used of it in the future,
that might be by accident.

Please instead keep the old base class and implement the Init(),
RequestPathAccess(), and the new CheckPathAccess() with a CHECK(false) /
ASSERT_TRUE(false).
(the include of fake_permission... above is wrong then)

[Reilly Grant (use Gerrit), 2015-04-07 20:12:10]

https://codereview.chromium.org/1034333002/diff/60001/chromeos/network/firewa...
File chromeos/network/firewall_hole_unittest.cc (right):

https://codereview.chromium.org/1034333002/diff/60001/chromeos/network/firewa...
chromeos/network/firewall_hole_unittest.cc:27: : public
chromeos::FakePermissionBrokerClient {
On 2015/04/07 07:57:38, pneubeck wrote:
> nothing of that fake is actually used. If anything is used of it in the
future,
> that might be by accident.
> 
> Please instead keep the old base class and implement the Init(),
> RequestPathAccess(), and the new CheckPathAccess() with a CHECK(false) /
> ASSERT_TRUE(false).
> (the include of fake_permission... above is wrong then)

I've moved MockPermissionBrokerClient into its own header and removed the
inheritance relationship to continue to avoid updating this file for unrelated
changes to the PermissionBrokerClient interface.

[Reilly Grant (use Gerrit), 2015-04-07 22:36:38]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2015-04-07 22:36:38]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
dgozman@chromium.org, pneubeck@chromium.org, hashimoto@chromium.org
Link to the patchset: https://codereview.chromium.org/1034333002/#ps80001
(title: "Move MockPermissionBrokerClient into its own header.")

[commit-bot: I haz the power, 2015-04-07 22:38:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1034333002/80001

[commit-bot: I haz the power, 2015-04-07 22:50:11]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-04-07 22:51:04]

Patchset 5 (id:??) landed as
https://crrev.com/556a9e9fddcc48e9b9650f2ac4a413ce4705efdf
Cr-Commit-Position: refs/heads/master@{#324139}