Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3239)

Unified Diff: chrome/browser/devtools/device/usb/android_usb_browsertest.cc

Issue 1034333002: Check USB device path access when prompting users to select a device. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move MockPermissionBrokerClient into its own header. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/devtools/device/usb/android_usb_device.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/device/usb/android_usb_browsertest.cc
diff --git a/chrome/browser/devtools/device/usb/android_usb_browsertest.cc b/chrome/browser/devtools/device/usb/android_usb_browsertest.cc
index 0c96628de1bbdac2731522c9b41a90d8089fab95..c7f99ed6dccf78c937fd6e3dde81d8567d3f7723 100644
--- a/chrome/browser/devtools/device/usb/android_usb_browsertest.cc
+++ b/chrome/browser/devtools/device/usb/android_usb_browsertest.cc
@@ -433,18 +433,6 @@ class MockUsbDevice : public UsbDevice {
return true;
}
-#if defined(OS_CHROMEOS)
- // On ChromeOS, if an interface of a claimed device is not claimed, the
- // permission broker can change the owner of the device so that the unclaimed
- // interfaces can be used. If this argument is missing, permission broker will
- // not be used and this method fails if the device is claimed.
- virtual void RequestUsbAccess(
- int interface_id,
- const base::Callback<void(bool success)>& callback) override {
- callback.Run(true);
- }
-#endif // OS_CHROMEOS
-
std::set<int> claimed_interfaces_;
protected:
« no previous file with comments | « no previous file | chrome/browser/devtools/device/usb/android_usb_device.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698