Check USB device path access when prompting users to select a device.

chromeos/network/firewall_hole_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/run_loop.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/fake_permission_broker_client.h"
 #include "chromeos/network/firewall_hole.h"
 #include "dbus/file_descriptor.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using chromeos::DBusThreadManager;
 using chromeos::FirewallHole;
 using testing::_;
 
 namespace {
 
 ACTION_TEMPLATE(InvokeCallback,
                 HAS_1_TEMPLATE_PARAMS(int, k),
                 AND_1_VALUE_PARAMS(p1)) {
   ::std::tr1::get<k>(args).Run(p1);
 }
 
-class MockPermissionsBrokerClient : public chromeos::PermissionBrokerClient {
+class MockPermissionsBrokerClient
+    : public chromeos::FakePermissionBrokerClient {

[pneubeck (no reviews), 2015/04/07 07:57:38]

nothing of that fake is actually used. If anything is used of it in the future,
that might be by accident.

Please instead keep the old base class and implement the Init(),
RequestPathAccess(), and the new CheckPathAccess() with a CHECK(false) /
ASSERT_TRUE(false).
(the include of fake_permission... above is wrong then)

[Reilly Grant (use Gerrit), 2015/04/07 20:12:10]

I've moved MockPermissionBrokerClient into its own header and removed the
inheritance relationship to continue to avoid updating this file for unrelated
changes to the PermissionBrokerClient interface.

  public:
   MockPermissionsBrokerClient() {}
   ~MockPermissionsBrokerClient() override {}
 
-  MOCK_METHOD1(Init, void(dbus::Bus* bus));
-  MOCK_METHOD3(RequestPathAccess,
-               void(const std::string& path,
-                    int interface_id,
-                    const ResultCallback& callback));
   MOCK_METHOD4(RequestTcpPortAccess,
                void(uint16 port,
                     const std::string& interface,
                     const dbus::FileDescriptor& lifeline_fd,
                     const ResultCallback& callback));
   MOCK_METHOD4(RequestUdpPortAccess,
                void(uint16 port,
                     const std::string& interface,
                     const dbus::FileDescriptor& lifeline_fd,
                     const ResultCallback& callback));
@@ skipping 80 matching lines @@
 TEST_F(FirewallHoleTest, DenyUdpPortAccess) {
   EXPECT_CALL(*mock_permissions_broker_client_,
               RequestUdpPortAccess(1234, "foo0", _, _))
       .WillOnce(InvokeCallback<3>(false));
 
   FirewallHole::Open(
       FirewallHole::PortType::UDP, 1234, "foo0",
       base::Bind(&FirewallHoleTest::AssertOpenFailure, base::Unretained(this)));
   run_loop_.Run();
 }