Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1033933004: Revert of Port Chromium OS touch noise filtering to Chromium (Closed)

Created:
5 years, 9 months ago by Mr4D (OOO till 08-26)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, kalyank, jdduke+watch_chromium.org, ozone-reviews_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Port Chromium OS touch noise filtering to Chromium (patchset #8 id:410001 of https://codereview.chromium.org/991533002/) Reason for revert: This patch breaks the PFQ for 32/64 bit due to some string conversion problems: 0.2346.0_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/ui/events/ozone/evdev/touch_noise/single_position_touch_noise_filter.cc:100:63: error: format '%ld' expects argument of type 'long int', but argument 3 has type 'int64 {aka long long int}' [-Werror=format=] chromeos-chrome-43.0.2346.0_rc-r1: touch.tracking_id, max_duration.InMilliseconds()); should I revert this - or do you want to land a patch for it? Oh - there is also another one: 0.2346.0_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/ui/events/ozone/evdev/touch_noise/horizontally_aligned_touch_noise_filter.cc: In member function 'virtual void ui::HorizontallyAlignedTouchNoiseFilter::Filter(const std::vector<ui::InProgressTouchEvdev>&, base::TimeDelta, std::bitset<20u>*)': chromeos-chrome-43.0.2346.0_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/ui/events/ozone/evdev/touch_noise/horizontally_aligned_touch_noise_filter.cc:39:66: error: format '%ld' expects argument of type 'long int', but argument 3 has type 'int64 {aka long long int}' [-Werror=format=] chromeos-chrome-43.0.2346.0_rc-r1: other_touch.tracking_id, other_touch.x, other_touch.y); Original issue's description: > Port Chromium OS touch noise filtering to Chromium. The Chromium OS > touch noise filtering is at > https://chromium.googlesource.com/chromiumos/platform/touch_noise_filter/+/master > > When a touch is detected as touch noise, an ET_TOUCH_CANCELLED event is sent and > all of the subsequent events for that touch are dropped. A "touch press" > initiates a new touch. > > BUG=407840 > TEST=TouchNoiseFinderTest.*, TouchEventConverterEvdevTouchNoiseTest.* > > Committed: https://crrev.com/1df4aa125090c601b1a18c4354b8ca9323cb4c79 > Cr-Commit-Position: refs/heads/master@{#322293} TBR=flackr@chromium.org,spang@chromium.org,pkotwicz@google.com,sadrul@chromium.org,pkotwicz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=407840 Committed: https://crrev.com/de2de99a0e380623ea8d2796578848fdcdc3f1ad Cr-Commit-Position: refs/heads/master@{#322415}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -1024 lines) Patch
M ui/events/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/event_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/event_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/events/events.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D ui/events/ozone/evdev/touch_evdev_types.h View 1 chunk +0 lines, -43 lines 0 comments Download
D ui/events/ozone/evdev/touch_evdev_types.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev.h View 6 chunks +24 lines, -15 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev.cc View 11 chunks +58 lines, -66 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev_unittest.cc View 10 chunks +28 lines, -184 lines 0 comments Download
D ui/events/ozone/evdev/touch_noise/far_apart_taps_touch_noise_filter.h View 1 chunk +0 lines, -46 lines 0 comments Download
D ui/events/ozone/evdev/touch_noise/far_apart_taps_touch_noise_filter.cc View 1 chunk +0 lines, -91 lines 0 comments Download
D ui/events/ozone/evdev/touch_noise/horizontally_aligned_touch_noise_filter.h View 1 chunk +0 lines, -29 lines 0 comments Download
D ui/events/ozone/evdev/touch_noise/horizontally_aligned_touch_noise_filter.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D ui/events/ozone/evdev/touch_noise/single_position_touch_noise_filter.h View 1 chunk +0 lines, -55 lines 0 comments Download
D ui/events/ozone/evdev/touch_noise/single_position_touch_noise_filter.cc View 1 chunk +0 lines, -151 lines 0 comments Download
D ui/events/ozone/evdev/touch_noise/touch_noise_filter.h View 1 chunk +0 lines, -26 lines 0 comments Download
D ui/events/ozone/evdev/touch_noise/touch_noise_finder.h View 1 chunk +0 lines, -48 lines 0 comments Download
D ui/events/ozone/evdev/touch_noise/touch_noise_finder.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D ui/events/ozone/evdev/touch_noise/touch_noise_finder_unittest.cc View 1 chunk +0 lines, -140 lines 0 comments Download
M ui/events/ozone/events_ozone.gyp View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mr4D (OOO till 08-26)
Created Revert of Port Chromium OS touch noise filtering to Chromium
5 years, 9 months ago (2015-03-26 17:41:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033933004/1
5 years, 9 months ago (2015-03-26 17:41:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 17:43:05 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 17:44:11 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de2de99a0e380623ea8d2796578848fdcdc3f1ad
Cr-Commit-Position: refs/heads/master@{#322415}

Powered by Google App Engine
This is Rietveld 408576698