Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: components/metrics/metrics_service.cc

Issue 1033493002: Histogram for UMA log upload connection type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Histogram type changed, refactoring network_metrics_provider_ + nits Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/metrics_service.cc
diff --git a/components/metrics/metrics_service.cc b/components/metrics/metrics_service.cc
index f86f33ab8b511b4d90afd011da3705426cfe4ba4..1e32073b515c0e5180c669c62ee5a11e817ea52e 100644
--- a/components/metrics/metrics_service.cc
+++ b/components/metrics/metrics_service.cc
@@ -997,7 +997,7 @@ void MetricsService::OnLogUploadComplete(int response_code) {
scheduler_->UploadFinished(server_is_healthy, log_manager_.has_unsent_logs());
if (server_is_healthy)
- client_->OnLogUploadComplete();
+ client_->OnLogUploadComplete(upload_succeeded);
Ilya Sherman 2015/03/24 21:55:44 I think we might be able to significantly reduce t
gayane -on leave until 09-2017 2015/03/25 21:02:33 I like this. Done.
}
void MetricsService::IncrementPrefValue(const char* path) {

Powered by Google App Engine
This is Rietveld 408576698