Histogram for UMA log upload connection type.

components/metrics/metrics_service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 //------------------------------------------------------------------------------
 // Description of the life cycle of a instance of MetricsService.
 //
 //  OVERVIEW
 //
 // A MetricsService instance is typically created at application startup.  It is
@@ skipping 979 matching lines @@
     // Store the updated list to disk now that the removed log is uploaded.
     log_manager_.PersistUnsentLogs();
   }
 
   // Error 400 indicates a problem with the log, not with the server, so
   // don't consider that a sign that the server is in trouble.
   bool server_is_healthy = upload_succeeded || response_code == 400;
   scheduler_->UploadFinished(server_is_healthy, log_manager_.has_unsent_logs());
 
   if (server_is_healthy)
-    client_->OnLogUploadComplete();
+    client_->OnLogUploadComplete(upload_succeeded);

[Ilya Sherman, 2015/03/24 21:55:44]

I think we might be able to significantly reduce the size of this CL by asking
the log_uploader_ to log the network metrics, rather than asking the client to
do so.  If we don't care about the Error 400 check above, we could even just
directly log the metric in NetMetricsLogUploader::OnURLFetchComplete().  WDYT?

[gayane -on leave until 09-2017, 2015/03/25 21:02:33]

I like this. Done.

 }
 
 void MetricsService::IncrementPrefValue(const char* path) {
   int value = local_state_->GetInteger(path);
   local_state_->SetInteger(path, value + 1);
 }
 
 void MetricsService::IncrementLongPrefsValue(const char* path) {
   int64 value = local_state_->GetInt64(path);
   local_state_->SetInt64(path, value + 1);
@@ skipping 118 matching lines @@
   local_state_->SetBoolean(path, value);
   RecordCurrentState(local_state_);
 }
 
 void MetricsService::RecordCurrentState(PrefService* pref) {
   pref->SetInt64(prefs::kStabilityLastTimestampSec,
                  base::Time::Now().ToTimeT());
 }
 
 }  // namespace metrics