chromecast/browser/metrics/cast_metrics_service_client.cc - Issue 1033493002: Histogram for UMA log upload connection type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/metrics/cast_metrics_service_client.cc

Issue 1033493002: Histogram for UMA log upload connection type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Histogram type changed, refactoring network_metrics_provider_ + nits Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromecast/browser/metrics/cast_metrics_service_client.cc

diff --git a/chromecast/browser/metrics/cast_metrics_service_client.cc b/chromecast/browser/metrics/cast_metrics_service_client.cc

index 48bf45bbfd2e70210c2a7f9bf800ee86e59fba9f..a041b467ee80cc51f5d863ef5b057b1a09441ced 100644

--- a/chromecast/browser/metrics/cast_metrics_service_client.cc

+++ b/chromecast/browser/metrics/cast_metrics_service_client.cc

@@ -122,7 +122,7 @@ std::string CastMetricsServiceClient::GetVersionString() {

return GetPlatformVersionString(cast_service_);

}

-void CastMetricsServiceClient::OnLogUploadComplete() {

+void CastMetricsServiceClient::OnLogUploadComplete(bool upload_succeeded) {

PlatformOnLogUploadComplete(cast_service_);

}