chromecast/browser/metrics/cast_metrics_service_client.h - Issue 1033493002: Histogram for UMA log upload connection type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/metrics/cast_metrics_service_client.h

Issue 1033493002: Histogram for UMA log upload connection type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Histogram type changed, refactoring network_metrics_provider_ + nits Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromecast/browser/metrics/cast_metrics_service_client.h

diff --git a/chromecast/browser/metrics/cast_metrics_service_client.h b/chromecast/browser/metrics/cast_metrics_service_client.h

index ffa17a3f8d16b7aafbb4023b4e9751636c33a5dc..7783f105e3a05326dbdaa3d98bf2f2802c1acec4 100644

--- a/chromecast/browser/metrics/cast_metrics_service_client.h

+++ b/chromecast/browser/metrics/cast_metrics_service_client.h

@@ -57,7 +57,7 @@ class CastMetricsServiceClient : public ::metrics::MetricsServiceClient {

bool GetBrand(std::string* brand_code) override;

::metrics::SystemProfileProto::Channel GetChannel() override;

std::string GetVersionString() override;

- void OnLogUploadComplete() override;

+ void OnLogUploadComplete(bool upload_succeeded) override;

void StartGatheringMetrics(const base::Closure& done_callback) override;

void CollectFinalMetrics(const base::Closure& done_callback) override;

scoped_ptr< ::metrics::MetricsLogUploader> CreateUploader(