Enable 'First-Party-Only' cookies by default.

Enable 'First-Party-Only' cookies by default.

This patch reverts https://codereview.chromium.org/940373002, and adds
back in the ~2 lines and tests that are still relevant.

BUG=459154
Committed: https://crrev.com/bdd0b09b5371066ad6d6c0ef2c32f5b92595316d
Cr-Commit-Position: refs/heads/master@{#322533}

[Mike West, 2015-03-25 08:36:09]

mkwst@chromium.org changed reviewers:
+ cbentzel@chromium.org, jochen@chromium.org, rsleevi@chromium.org

[Mike West, 2015-03-25 08:36:10]

Hi Ryan, Chris, and Jochen.

Assuming that the patch is correct, what is the right set of OWNERS to approve
shipping this feature? The thread's outcome wasn't really clear to me.

-mike

[jochen (gone - plz use gerrit), 2015-03-25 12:25:49]

me + somebody from the network stack team

[Mike West, 2015-03-25 15:32:34]

On 2015/03/25 at 12:25:49, jochen wrote:
> me + somebody from the network stack team

Sounds good.

Oh, hey look! You and two somebodies from the network stack team are listed as
reviewers on this CL. What a coincidence! :)

[cbentzel, 2015-03-26 05:42:23]

On 2015/03/25 15:32:34, Mike West wrote:
> On 2015/03/25 at 12:25:49, jochen wrote:
> > me + somebody from the network stack team
> 
> Sounds good.
> 
> Oh, hey look! You and two somebodies from the network stack team are listed as
> reviewers on this CL. What a coincidence! :)

I assume that the blink-dev ItS thread was sufficient for whether this should
land from a policy perspective. Jochen, happy to hear contrary evidence. 

From a code review perspective I am becoming increasingly useless but will take
a first pass and see if someone else should take it on.

[Mike West, 2015-03-26 07:30:20]

On 2015/03/26 at 05:42:23, cbentzel wrote:
> From a code review perspective I am becoming increasingly useless but will
take a first pass and see if someone else should take it on.

Code reviews are easy. You just need to hit the button labeled "Quick L-G-T-M"
and then move on to the next one. That's what I do!

This patch is pretty much a revert of the pipework added in
https://codereview.chromium.org/940373002 that exposed the command-line flag to
//net, coupled with a 1-line change to `url_request_http_job.cc`. I hope it's
straightforward enough.

[jochen (gone - plz use gerrit), 2015-03-26 15:38:29]

the bots don't like it?

[Mike West, 2015-03-26 15:42:15]

On 2015/03/26 at 15:38:29, jochen wrote:
> the bots don't like it?

This is what happens when I try to simplify. The previous patchset is all green,
this one was supposed to make the chrome network delegate unit test changes
easier to review. Let's pretend that didn't happen.

[jochen (gone - plz use gerrit), 2015-03-26 15:42:50]

lgtm for the green patchset

[cbentzel, 2015-03-26 21:03:12]

On 2015/03/26 15:42:50, jochen wrote:
> lgtm for the green patchset

Happy with patch once trybots don't run into compile issues.

[Mike West, 2015-03-26 21:11:59]

I'm pretty sure the latest patch will compile. I forgot to unrevert a friended
class' rename. :/

https://codereview.chromium.org/1032063002/diff/20001/chrome/browser/net/chro...
File chrome/browser/net/chrome_network_delegate.h (right):

https://codereview.chromium.org/1032063002/diff/20001/chrome/browser/net/chro...
chrome/browser/net/chrome_network_delegate.h:139: friend class
ChromeNetworkDelegateTest;
I shouldn't have changed this back. :/

[cbentzel, 2015-03-26 21:48:55]

On 2015/03/26 21:11:59, Mike West wrote:
> I'm pretty sure the latest patch will compile. I forgot to unrevert a friended
> class' rename. :/
> 
>
https://codereview.chromium.org/1032063002/diff/20001/chrome/browser/net/chro...
> File chrome/browser/net/chrome_network_delegate.h (right):
> 
>
https://codereview.chromium.org/1032063002/diff/20001/chrome/browser/net/chro...
> chrome/browser/net/chrome_network_delegate.h:139: friend class
> ChromeNetworkDelegateTest;
> I shouldn't have changed this back. :/

LGTM

[Mike West, 2015-03-27 04:58:58]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2015-03-27 04:58:59]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1032063002/#ps40001
(title: "Friend.")

[commit-bot: I haz the power, 2015-03-27 04:59:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1032063002/40001

[commit-bot: I haz the power, 2015-03-27 05:03:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-27 05:04:38]

Patchset 3 (id:??) landed as
https://crrev.com/bdd0b09b5371066ad6d6c0ef2c32f5b92595316d
Cr-Commit-Position: refs/heads/master@{#322533}

[Mike West, 2015-04-01 05:52:11]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1043403003/ by mkwst@chromium.org.

The reason for reverting is: Blink OWNERs would like to wait a bit before
shipping:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/wKZBCzcNssg/nZ1CFmgd....