Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Issue 1031843002: Move IdleTask to WebThread side 1/3 (Closed)

Created:
5 years, 9 months ago by alex clarke (OOO till 29th)
Modified:
5 years, 9 months ago
CC:
blink-reviews, dglazkov+blink, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move IdleTask to WebThread side 1/3 Initial step in a three sided patch to move IdleTask to WebThread. This is needed because we plan to introduce a scheduler for worker threads, and they will use the WebThread interface for posting idle tasks. Other patches https://codereview.chromium.org/1029343002 and https://codereview.chromium.org/1029803002 BUG=463143 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192439

Patch Set 1 #

Patch Set 2 : Fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M Source/platform/scheduler/Scheduler.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/scheduler/SchedulerTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebScheduler.h View 1 chunk +1 line, -7 lines 0 comments Download
M public/platform/WebThread.h View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
alex clarke (OOO till 29th)
5 years, 9 months ago (2015-03-24 11:24:30 UTC) #2
rmcilroy
Fix typo in description - /s/WebThrad/WebThread/ otherwise lgtm.
5 years, 9 months ago (2015-03-24 12:40:37 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-24 13:16:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031843002/20001
5 years, 9 months ago (2015-03-24 13:50:43 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 15:22:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192439

Powered by Google App Engine
This is Rietveld 408576698