Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1029343002: Move IdleTask to WebThread side 2/3 (Closed)

Created:
5 years, 9 months ago by alex clarke (OOO till 29th)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, ben+mojo_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move IdleTask to WebThread side 2/3 Second step of a a three sided patch to move IdleTask to WebThread. This is needed because we plan to introduce a scheduler for worker threads, and they will use the WebTherad interface for posting idle tasks. Other patches https://codereview.chromium.org/1031843002/ and https://codereview.chromium.org/1029803002 BUG=463143 Committed: https://crrev.com/2e2647b9a70d35ced01dbf3a35ea2647bebbf025 Cr-Commit-Position: refs/heads/master@{#322443}

Patch Set 1 #

Total comments: 1

Patch Set 2 : run git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
M content/renderer/scheduler/web_scheduler_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/scheduler/web_scheduler_impl.cc View 1 4 chunks +8 lines, -9 lines 0 comments Download
M mojo/services/html_viewer/webscheduler_impl.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/webscheduler_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
alex clarke (OOO till 29th)
5 years, 9 months ago (2015-03-24 11:25:20 UTC) #2
rmcilroy
Same typo in description. Otherwise renderer/scheduler lgtm.
5 years, 9 months ago (2015-03-24 12:44:08 UTC) #3
jamesr
mojo/ lgtm https://codereview.chromium.org/1029343002/diff/1/mojo/services/html_viewer/webscheduler_impl.h File mojo/services/html_viewer/webscheduler_impl.h (right): https://codereview.chromium.org/1029343002/diff/1/mojo/services/html_viewer/webscheduler_impl.h#newcode23 mojo/services/html_viewer/webscheduler_impl.h:23: blink::WebThread::IdleTask* task); this is misaligned - please ...
5 years, 9 months ago (2015-03-26 18:05:30 UTC) #5
alex clarke (OOO till 29th)
On 2015/03/26 18:05:30, jamesr wrote: > mojo/ lgtm > > https://codereview.chromium.org/1029343002/diff/1/mojo/services/html_viewer/webscheduler_impl.h > File mojo/services/html_viewer/webscheduler_impl.h (right): ...
5 years, 9 months ago (2015-03-26 18:11:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029343002/20001
5 years, 9 months ago (2015-03-26 18:13:04 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-26 19:22:40 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 19:23:37 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2e2647b9a70d35ced01dbf3a35ea2647bebbf025
Cr-Commit-Position: refs/heads/master@{#322443}

Powered by Google App Engine
This is Rietveld 408576698