Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1029803002: Move IdleTask to WebThread side 3/3 (Closed)

Created:
5 years, 9 months ago by alex clarke (OOO till 29th)
Modified:
5 years, 9 months ago
CC:
blink-reviews, dglazkov+blink, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move IdleTask to WebThread side 3/3 Final step in a three sided patch to move IdleTask to WebThread. This is needed because we plan to introduce a scheduler for worker threads, and they will use the WebThread interface for posting idle tasks. Other patches https://codereview.chromium.org/1031843002/ and https://codereview.chromium.org/1029343002/ BUG=463143 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192671

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M Source/platform/scheduler/SchedulerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebScheduler.h View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
alex clarke (OOO till 29th)
5 years, 9 months ago (2015-03-24 11:25:56 UTC) #2
rmcilroy
On 2015/03/24 11:25:56, alexclarke1 wrote: Same typo in description. Otherwise lgtm.
5 years, 9 months ago (2015-03-24 12:44:14 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-24 13:16:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029803002/20001
5 years, 9 months ago (2015-03-27 10:10:25 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 11:49:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192671

Powered by Google App Engine
This is Rietveld 408576698