Issue 103143009: Add a setTimer() function.

Issue 103143009: Add a setTimer() function. (Closed)

Created:
7 years ago by jcgregorio

Modified:
7 years ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Add a setTimer() function. Seemed simple, but required adding a Global class that contains all the global state (instance and context) for our running V8 instance. Also moved canvas.inval to be just inval() at the global level. BUG= Committed: http://code.google.com/p/skia/source/detail?r=12730

Patch Set 1 #

Patch Set 2 : 80 cols #

Patch Set 3 : spacing #

Total comments: 30

Patch Set 4 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+396 lines, -200 lines)			Patch
A	experimental/SkV8Example/Global.h	View	1 2 3	1 chunk	+74 lines, -0 lines	0 comments	Download
A	experimental/SkV8Example/Global.cpp	View	1 2 3	1 chunk	+232 lines, -0 lines	0 comments	Download
M	experimental/SkV8Example/SkV8Example.h	View		4 chunks	+6 lines, -16 lines	0 comments	Download
M	experimental/SkV8Example/SkV8Example.cpp	View	1 2 3	11 chunks	+73 lines, -182 lines	0 comments	Download
M	experimental/SkV8Example/sample.js	View		1 chunk	+9 lines, -2 lines	0 comments	Download
M	gyp/v8.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + nits https://codereview.chromium.org/103143009/diff/40001/experimental/SkV8Example/Global.cpp File experimental/SkV8Example/Global.cpp (right): https://codereview.chromium.org/103143009/diff/40001/experimental/SkV8Example/Global.cpp#newcode1 experimental/SkV8Example/Global.cpp:1: #include "Global.h" Header! https://codereview.chromium.org/103143009/diff/40001/experimental/SkV8Example/Global.cpp#newcode9 experimental/SkV8Example/Global.cpp:9: // ...

7 years ago (2013-12-17 23:35:53 UTC) #2

jcgregorio

https://codereview.chromium.org/103143009/diff/40001/experimental/SkV8Example/Global.cpp File experimental/SkV8Example/Global.cpp (right): https://codereview.chromium.org/103143009/diff/40001/experimental/SkV8Example/Global.cpp#newcode1 experimental/SkV8Example/Global.cpp:1: #include "Global.h" On 2013/12/17 23:35:53, robertphillips wrote: > Header! ...

7 years ago (2013-12-18 04:32:53 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/103143009/60001

7 years ago (2013-12-18 04:33:22 UTC) #4

Message was sent while issue was closed.

Change committed as 12730

Expand Messages | Collapse Messages