Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1030743002: Path 1 of 4: Move blink image resources to blink. (Closed)

Created:
5 years, 9 months ago by Elliot Glaysher
Modified:
5 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Path 1 of 4: Move blink image resources to blink. This first patch allocates resource ids for the image structures in blink. It then temporarily renames current usage of all these symbols from IDR_* to IDR2_* so that we don't conflict on names once we land part 2. BUG=467176 Committed: https://crrev.com/e3d696a2fa3861c2cd9a23192248d9107ebd8432 Cr-Commit-Position: refs/heads/master@{#321913}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -102 lines) Patch
M content/app/resources/content_resources.grd View 2 chunks +48 lines, -48 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 chunk +50 lines, -50 lines 0 comments Download
M content/shell/common/shell_content_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Elliot Glaysher
This will be a four sided patch, and I'd like to get parts 1 and ...
5 years, 9 months ago (2015-03-23 21:28:51 UTC) #2
jam
lgtm
5 years, 9 months ago (2015-03-23 23:22:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030743002/1
5 years, 9 months ago (2015-03-23 23:23:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 00:49:09 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 00:50:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3d696a2fa3861c2cd9a23192248d9107ebd8432
Cr-Commit-Position: refs/heads/master@{#321913}

Powered by Google App Engine
This is Rietveld 408576698