Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1373)

Issue 1029953003: Remove the intent to turn on Wextra for gcc (except MacOS) (Closed)

Created:
5 years, 9 months ago by lgombos
Modified:
5 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the intent to turn on Wextra for gcc (except MacOS). We use clang with Wextra which seems to be more reliable and report less false positives. We no longer have an intent to turn on Wextra for gcc on posix-like systems any more (except MacOS). Committed: https://crrev.com/2ca5097c4db8905beba3c37a47f40b21b97877a0 Cr-Commit-Position: refs/heads/master@{#322101}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
lgombos
Nico, would you mind rubber stamping this this CL again ? Commit queue is not ...
5 years, 9 months ago (2015-03-24 20:50:14 UTC) #2
Nico
lgtm
5 years, 9 months ago (2015-03-24 21:11:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029953003/1
5 years, 9 months ago (2015-03-24 21:29:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 00:11:54 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 00:12:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ca5097c4db8905beba3c37a47f40b21b97877a0
Cr-Commit-Position: refs/heads/master@{#322101}

Powered by Google App Engine
This is Rietveld 408576698