build/common.gypi - Issue 1029953003: Remove the intent to turn on Wextra for gcc (except MacOS)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 1029953003: Remove the intent to turn on Wextra for gcc (except MacOS) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 745035c5503f8c5fb9c85b8c4408d4b49b142826..d02cf11c2aff683b3ecdea021e1b9cb9c07f6141 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -3603,8 +3603,6 @@

'-pthread',

'-fno-strict-aliasing', # See http://crbug.com/32204

'-Wall',

- # TODO(evan): turn this back on once all the builds work.

- # '-Wextra',

# Don't warn about unused function params. We use those everywhere.

'-Wno-unused-parameter',

# Don't warn about the "struct foo f = {0};" initialization pattern.

« no previous file with comments | « no previous file | no next file » | no next file with comments »