Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1180)

Side by Side Diff: build/common.gypi

Issue 1029953003: Remove the intent to turn on Wextra for gcc (except MacOS) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 3585 matching lines...) Expand 10 before | Expand all | Expand 10 after
3596 'libraries_for_target%': '', 3596 'libraries_for_target%': '',
3597 }, 3597 },
3598 'defines': [ 3598 'defines': [
3599 '_FILE_OFFSET_BITS=64', 3599 '_FILE_OFFSET_BITS=64',
3600 ], 3600 ],
3601 'cflags': [ 3601 'cflags': [
3602 '<(werror)', # See note above about the werror variable. 3602 '<(werror)', # See note above about the werror variable.
3603 '-pthread', 3603 '-pthread',
3604 '-fno-strict-aliasing', # See http://crbug.com/32204 3604 '-fno-strict-aliasing', # See http://crbug.com/32204
3605 '-Wall', 3605 '-Wall',
3606 # TODO(evan): turn this back on once all the builds work.
3607 # '-Wextra',
3608 # Don't warn about unused function params. We use those everywhere. 3606 # Don't warn about unused function params. We use those everywhere.
3609 '-Wno-unused-parameter', 3607 '-Wno-unused-parameter',
3610 # Don't warn about the "struct foo f = {0};" initialization pattern. 3608 # Don't warn about the "struct foo f = {0};" initialization pattern.
3611 '-Wno-missing-field-initializers', 3609 '-Wno-missing-field-initializers',
3612 # Don't export any symbols (for example, to plugins we dlopen()). 3610 # Don't export any symbols (for example, to plugins we dlopen()).
3613 # Note: this is *required* to make some plugins work. 3611 # Note: this is *required* to make some plugins work.
3614 '-fvisibility=hidden', 3612 '-fvisibility=hidden',
3615 '-pipe', 3613 '-pipe',
3616 ], 3614 ],
3617 'cflags_cc': [ 3615 'cflags_cc': [
(...skipping 2475 matching lines...) Expand 10 before | Expand all | Expand 10 after
6093 # settings in target dicts. SYMROOT is a special case, because many other 6091 # settings in target dicts. SYMROOT is a special case, because many other
6094 # Xcode variables depend on it, including variables such as 6092 # Xcode variables depend on it, including variables such as
6095 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6093 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6096 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6094 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6097 # files to appear (when present) in the UI as actual files and not red 6095 # files to appear (when present) in the UI as actual files and not red
6098 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6096 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6099 # and therefore SYMROOT, needs to be set at the project level. 6097 # and therefore SYMROOT, needs to be set at the project level.
6100 'SYMROOT': '<(DEPTH)/xcodebuild', 6098 'SYMROOT': '<(DEPTH)/xcodebuild',
6101 }, 6099 },
6102 } 6100 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698