Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 102963010: Move SynchronousCompositorFactoryImpl into separate h/cc files (Closed)

Created:
6 years, 11 months ago by boliu
Modified:
6 years, 11 months ago
Reviewers:
Ted C, Avi (use Gerrit)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Move SynchronousCompositorFactoryImpl into separate h/cc files This is a long overdue clean up to make future changes in this area saner. Only shuffling code and these cosmetic changes: Removed unused SynchronousCompositorImpl* argument from SynchronousCompositorFactoryImpl::CompositorInitializedHardwareDraw and SynchronousCompositorFactoryImpl::CompositorReleasedHardwareDraw. Add virtual SynchronousCompositorFactory destructor. BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243314

Patch Set 1 #

Patch Set 2 : remove TODO comment #

Patch Set 3 : move a TODO comment #

Total comments: 2

Patch Set 4 : style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -230 lines) Patch
A content/browser/android/in_process/synchronous_compositor_factory_impl.h View 1 chunk +83 lines, -0 lines 0 comments Download
A content/browser/android/in_process/synchronous_compositor_factory_impl.cc View 1 2 3 1 chunk +209 lines, -0 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_impl.cc View 1 4 chunks +3 lines, -229 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/android/synchronous_compositor_factory.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
boliu
avi - stamp content_browser.gypi tedchoc - rest of the android files
6 years, 11 months ago (2014-01-06 22:23:46 UTC) #1
Avi (use Gerrit)
lgtm gypi stamp
6 years, 11 months ago (2014-01-06 22:54:29 UTC) #2
Ted C
lgtm https://codereview.chromium.org/102963010/diff/50001/content/browser/android/in_process/synchronous_compositor_factory_impl.cc File content/browser/android/in_process/synchronous_compositor_factory_impl.cc (right): https://codereview.chromium.org/102963010/diff/50001/content/browser/android/in_process/synchronous_compositor_factory_impl.cc#newcode52 content/browser/android/in_process/synchronous_compositor_factory_impl.cc:52: : wrapped_gl_context_for_main_thread_(NULL), num_hardware_compositors_(0) { does num_hardware_compositors_ need to ...
6 years, 11 months ago (2014-01-07 00:31:08 UTC) #3
boliu
https://codereview.chromium.org/102963010/diff/50001/content/browser/android/in_process/synchronous_compositor_factory_impl.cc File content/browser/android/in_process/synchronous_compositor_factory_impl.cc (right): https://codereview.chromium.org/102963010/diff/50001/content/browser/android/in_process/synchronous_compositor_factory_impl.cc#newcode52 content/browser/android/in_process/synchronous_compositor_factory_impl.cc:52: : wrapped_gl_context_for_main_thread_(NULL), num_hardware_compositors_(0) { On 2014/01/07 00:31:09, Ted C ...
6 years, 11 months ago (2014-01-07 00:39:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/102963010/130001
6 years, 11 months ago (2014-01-07 00:41:10 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242275
6 years, 11 months ago (2014-01-07 12:30:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/102963010/130001
6 years, 11 months ago (2014-01-07 17:06:33 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 17:07:47 UTC) #8
Message was sent while issue was closed.
Change committed as 243314

Powered by Google App Engine
This is Rietveld 408576698