Android HWUI backend Nanobench

Android HWUI backend Nanobench

Uses filtering canvas from utils/android, shared with DM.
Follow-up plans in https://skbug.com/3589, https://skbug.com/3595

R=djsollen@google.com

Committed: https://skia.googlesource.com/skia/+/d968a6f29e92230ee118ec9cdfff0329bf83d602

[tomhudson, 2015-03-26 17:46:26]

PTAL

[djsollen, 2015-03-26 17:57:33]

lgtm with nits

https://codereview.chromium.org/1029423010/diff/1/bench/nanobench.cpp
File bench/nanobench.cpp (right):

https://codereview.chromium.org/1029423010/diff/1/bench/nanobench.cpp#newcode38
bench/nanobench.cpp:38: #include "nanobenchAndroid.h"
indent for consistency

https://codereview.chromium.org/1029423010/diff/1/bench/nanobenchAndroid.h
File bench/nanobenchAndroid.h (right):

https://codereview.chromium.org/1029423010/diff/1/bench/nanobenchAndroid.h#ne...
bench/nanobenchAndroid.h:36: void setup() SK_OVERRIDE;
just use override :)

https://codereview.chromium.org/1029423010/diff/1/gyp/bench.gyp
File gyp/bench.gyp (right):

https://codereview.chromium.org/1029423010/diff/1/gyp/bench.gyp#newcode54
gyp/bench.gyp:54: 'utils.gyp:android_utils',
what is this needed for?

[tomhudson, 2015-03-26 18:05:03]

https://codereview.chromium.org/1029423010/diff/1/bench/nanobench.cpp
File bench/nanobench.cpp (right):

https://codereview.chromium.org/1029423010/diff/1/bench/nanobench.cpp#newcode38
bench/nanobench.cpp:38: #include "nanobenchAndroid.h"
On 2015/03/26 17:57:33, djsollen wrote:
> indent for consistency

Done.
Although I'd rather de-indent the SUPPORT_GPU clause :P

https://codereview.chromium.org/1029423010/diff/1/bench/nanobenchAndroid.h
File bench/nanobenchAndroid.h (right):

https://codereview.chromium.org/1029423010/diff/1/bench/nanobenchAndroid.h#ne...
bench/nanobenchAndroid.h:36: void setup() SK_OVERRIDE;
On 2015/03/26 17:57:33, djsollen wrote:
> just use override :)

Done.
(Race conditions)

https://codereview.chromium.org/1029423010/diff/1/gyp/bench.gyp
File gyp/bench.gyp (right):

https://codereview.chromium.org/1029423010/diff/1/gyp/bench.gyp#newcode54
gyp/bench.gyp:54: 'utils.gyp:android_utils',
On 2015/03/26 17:57:33, djsollen wrote:
> what is this needed for?

SkAndroidSDKCanvas?
(Now from previous reviews, I realize that if we have the dependency I shouldn't
also need the src/utils/android addition to include_dirs...)

[tomhudson, 2015-03-26 18:17:56]

The CQ bit was checked by tomhudson@google.com

[tomhudson, 2015-03-26 18:17:57]

The patchset sent to the CQ was uploaded after l-g-t-m from djsollen@google.com
Link to the patchset: https://codereview.chromium.org/1029423010/#ps20001
(title: "Respond to Derek's review")

[commit-bot: I haz the power, 2015-03-26 18:18:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1029423010/20001

[commit-bot: I haz the power, 2015-03-26 18:19:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-26 18:19:29]

Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[tomhudson, 2015-03-26 18:21:42]

The CQ bit was checked by tomhudson@google.com

[tomhudson, 2015-03-26 18:21:42]

The patchset sent to the CQ was uploaded after l-g-t-m from djsollen@google.com
Link to the patchset: https://codereview.chromium.org/1029423010/#ps40001
(title: "More SK_OVERRIDE vs override racing")

[commit-bot: I haz the power, 2015-03-26 18:22:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1029423010/40001

[commit-bot: I haz the power, 2015-03-26 18:28:13]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/d968a6f29e92230ee118ec9cdfff0329bf83d602