Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1029343003: Turn css3/unicode-bidi-isolate-basic into a reftest. (Closed)

Created:
5 years, 9 months ago by mstensho (USE GERRIT)
Modified:
5 years, 9 months ago
Reviewers:
rune, eae, rune
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Turn css3/unicode-bidi-isolate-basic into a reftest. BUG=386567 R=rune@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192637

Patch Set 1 #

Patch Set 2 : rebase master #

Total comments: 3

Patch Set 3 : code review #

Messages

Total messages: 13 (3 generated)
mstensho (USE GERRIT)
5 years, 9 months ago (2015-03-24 12:53:47 UTC) #1
rune
This test doesn't look very robust. Displaying it in my Opera/Linux desktop browser shows red ...
5 years, 9 months ago (2015-03-26 09:46:09 UTC) #3
rune
https://codereview.chromium.org/1029343003/diff/20001/LayoutTests/css3/unicode-bidi-isolate-basic-expected.html File LayoutTests/css3/unicode-bidi-isolate-basic-expected.html (right): https://codereview.chromium.org/1029343003/diff/20001/LayoutTests/css3/unicode-bidi-isolate-basic-expected.html#newcode2 LayoutTests/css3/unicode-bidi-isolate-basic-expected.html:2: <html> Make the reference as small as possible and ...
5 years, 9 months ago (2015-03-26 09:48:41 UTC) #4
mstensho (USE GERRIT)
On 2015/03/26 09:46:09, rune wrote: > This test doesn't look very robust. Displaying it in ...
5 years, 9 months ago (2015-03-26 10:07:09 UTC) #5
mstensho (USE GERRIT)
https://codereview.chromium.org/1029343003/diff/20001/LayoutTests/css3/unicode-bidi-isolate-basic-expected.html File LayoutTests/css3/unicode-bidi-isolate-basic-expected.html (right): https://codereview.chromium.org/1029343003/diff/20001/LayoutTests/css3/unicode-bidi-isolate-basic-expected.html#newcode2 LayoutTests/css3/unicode-bidi-isolate-basic-expected.html:2: <html> On 2015/03/26 09:48:41, rune wrote: > Make the ...
5 years, 9 months ago (2015-03-26 10:07:17 UTC) #6
mstensho (USE GERRIT)
Decided against removing the red-bleeding-through that makes the text slightly brown-ish (not introduced by me). ...
5 years, 9 months ago (2015-03-26 11:08:25 UTC) #7
eae
LGTM assuming rune is happy with it.
5 years, 9 months ago (2015-03-26 21:12:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029343003/40001
5 years, 9 months ago (2015-03-26 21:53:32 UTC) #11
rune
ok
5 years, 9 months ago (2015-03-26 22:56:11 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 23:21:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192637

Powered by Google App Engine
This is Rietveld 408576698