Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Issue 1029313003: [Android WebView] Add tests for catching console messages on denied loads (Closed)

Created:
5 years, 9 months ago by mnaganov (inactive)
Modified:
5 years, 9 months ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android WebView] Add tests for catching console messages on denied loads Add test imitating several well-known situations where loading is blocked by Blink. Verify that clients can know about blocks via WebChromeClient.onConsoleMessage. Remove traces of previous attempt to add ERR_BLOCKED code. BUG=456782 Committed: https://crrev.com/77197c1c88f260f3885dfa0962d1f899bd507859 Cr-Commit-Position: refs/heads/master@{#322185}

Patch Set 1 #

Messages

Total messages: 8 (2 generated)
mnaganov (inactive)
5 years, 9 months ago (2015-03-24 14:43:10 UTC) #2
sgurun-gerrit only
lgtm
5 years, 9 months ago (2015-03-24 19:00:17 UTC) #3
sgurun-gerrit only
On 2015/03/24 19:00:17, sgurun wrote: > lgtm landing this since Mikhail is on vacation.
5 years, 9 months ago (2015-03-25 17:02:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029313003/1
5 years, 9 months ago (2015-03-25 17:03:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 17:25:30 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 17:26:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77197c1c88f260f3885dfa0962d1f899bd507859
Cr-Commit-Position: refs/heads/master@{#322185}

Powered by Google App Engine
This is Rietveld 408576698