Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1943)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java

Issue 1029313003: [Android WebView] Add tests for catching console messages on denied loads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/ConsoleMessagesForBlockedLoadsTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java b/android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java
index a890f5d2b38cddf9a8630035f815d1869f9bccb4..d36861232ecdad48f98a113a0a3e01f0cdbe4553 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java
@@ -19,6 +19,9 @@ import org.chromium.content.browser.test.util.TestCallbackHelperContainer.OnPage
import org.chromium.content.browser.test.util.TestCallbackHelperContainer.OnPageStartedHelper;
import org.chromium.content.browser.test.util.TestCallbackHelperContainer.OnReceivedErrorHelper;
+import java.util.ArrayList;
+import java.util.List;
+
/**
* AwContentsClient subclass used for testing.
*/
@@ -327,8 +330,7 @@ public class TestAwContentsClient extends NullContentsClient {
@Override
public boolean onConsoleMessage(ConsoleMessage consoleMessage) {
- mAddMessageToConsoleHelper.notifyCalled(consoleMessage.messageLevel().ordinal(),
- consoleMessage.message(), consoleMessage.lineNumber(), consoleMessage.sourceId());
+ mAddMessageToConsoleHelper.notifyCalled(consoleMessage);
return false;
}
@@ -336,36 +338,42 @@ public class TestAwContentsClient extends NullContentsClient {
* Callback helper for AddMessageToConsole.
*/
public static class AddMessageToConsoleHelper extends CallbackHelper {
- private int mLevel;
- private String mMessage;
- private int mLineNumber;
- private String mSourceId;
+ private List<ConsoleMessage> mMessages = new ArrayList<ConsoleMessage>();
+
+ public void clearMessages() {
+ mMessages.clear();
+ }
+
+ public List<ConsoleMessage> getMessages() {
+ return mMessages;
+ }
public int getLevel() {
assert getCallCount() > 0;
- return mLevel;
+ return getLastMessage().messageLevel().ordinal();
}
public String getMessage() {
assert getCallCount() > 0;
- return mMessage;
+ return getLastMessage().message();
}
public int getLineNumber() {
assert getCallCount() > 0;
- return mLineNumber;
+ return getLastMessage().lineNumber();
}
public String getSourceId() {
assert getCallCount() > 0;
- return mSourceId;
+ return getLastMessage().sourceId();
+ }
+
+ private ConsoleMessage getLastMessage() {
+ return mMessages.get(mMessages.size() - 1);
}
- void notifyCalled(int level, String message, int lineNumer, String sourceId) {
- mLevel = level;
- mMessage = message;
- mLineNumber = lineNumer;
- mSourceId = sourceId;
+ void notifyCalled(ConsoleMessage message) {
+ mMessages.add(message);
notifyCalled();
}
}
« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/ConsoleMessagesForBlockedLoadsTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698