Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1984)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedError2Test.java

Issue 1029313003: [Android WebView] Add tests for catching console messages on denied loads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedError2Test.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedError2Test.java b/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedError2Test.java
index 971938d20ff9ad39133297be62ad93d6f52b1faf..c5ab9dae9ab43e2abb35b1a4b26ddb61dfc11c26 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedError2Test.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedError2Test.java
@@ -380,37 +380,4 @@ public class ClientOnReceivedError2Test extends AwTestBase {
assertEquals(onReceivedError2CallCount + 1, onReceivedError2Helper.getCallCount());
assertEquals(BAD_HTML_URL, onReceivedError2Helper.getRequest().url);
}
-
- /*
- * TODO(mnaganov): Implement, add tests for other security blocks in Blink.
- @SmallTest
- @Feature({"AndroidWebView"})
- public void testOnXFrameOptionsDenial() throws Throwable {
- startWebServer();
- final String iframeHtml = CommonResources.makeHtmlPageFrom(
- "", "You shouldn't see me :)");
- List<Pair<String, String>> iframeHeaders = new ArrayList<Pair<String, String>>();
- iframeHeaders.add(Pair.create("x-frame-options", "DENY"));
- final String iframeUrl = mWebServer.setResponse("/iframe.html", iframeHeaders);
- final String pageHtml = CommonResources.makeHtmlPageFrom(
- "", "<iframe src='" + iframeUrl + "' />");
- getAwSettingsOnUiThread(mAwContents).setCacheMode(WebSettings.LOAD_CACHE_ONLY);
- loadDataSync(mAwContents, mContentsClient.getOnPageFinishedHelper(),
- pageHtml, "text/html", false);
-
- TestAwContentsClient.OnReceivedError2Helper onReceivedError2Helper =
- mContentsClient.getOnReceivedError2Helper();
- AwWebResourceRequest request = onReceivedError2Helper.getRequest();
- assertNotNull(request);
- assertEquals(iframeUrl, request.url);
- assertEquals("GET", request.method);
- assertNotNull(request.requestHeaders);
- assertFalse(request.requestHeaders.isEmpty());
- assertFalse(request.isMainFrame);
- assertFalse(request.hasUserGesture);
- AwWebResourceError error = onReceivedError2Helper.getError();
- assertEquals(ErrorCodeConversionHelper.ERROR_BLOCKED, error.errorCode);
- assertNotNull(error.description);
- }
- */
}

Powered by Google App Engine
This is Rietveld 408576698