Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 102873002: Move GetFileSize, NormalizeFilePath to base namespace (Closed)

Created:
7 years ago by brettw
Modified:
7 years ago
Reviewers:
viettrungluu
CC:
chromium-reviews, asanka, vandebo (ex-Chrome), nkostylev+watch_chromium.org, tzik, shishir+watch_chromium.org, alecflett, amit, browser-components-watch_chromium.org, dgrogan, kinuko+watch, stevenjb+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, benjhayden+dwatch_chromium.org, grt+watch_chromium.org, jam, joi+watch-content_chromium.org, marja+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, cmumford, fischman+watch_chromium.org, nhiroki, feature-media-reviews_chromium.org, dsinclair+watch_chromium.org, oshima+watch_chromium.org, jsbell, Lei Zhang, tfarina, mcasas+watch_chromium.org, tommycli, dominich+watch_chromium.org, eroman, robertshield, davemoore+watch_chromium.org, Greg Billock, wjia+watch_chromium.org, mmenke
Visibility:
Public.

Description

Move GetFileSize, NormalizeFilePath to base namespace BUG= R=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238722

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -330 lines) Patch
M base/file_util.h View 2 chunks +8 lines, -9 lines 0 comments Download
M base/file_util.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M base/file_util_posix.cc View 3 chunks +16 lines, -17 lines 0 comments Download
M base/file_util_unittest.cc View 1 11 chunks +17 lines, -20 lines 0 comments Download
M base/file_util_win.cc View 1 2 chunks +12 lines, -12 lines 0 comments Download
M base/files/file_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M base/platform_file_unittest.cc View 1 12 chunks +109 lines, -109 lines 0 comments Download
M base/test/test_file_util_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/open_file_operation_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/truncate_operation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/install_limiter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/owner_key_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/diagnostics/recon_diagnostics.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/download/save_page_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/drive/drive_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/sandboxed_unpacker.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/history/history_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/thumbnail_database.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/net/net_log_temp_file_unittest.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/net/sqlite_server_bound_cert_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/parsers/metadata_parser_filebase.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/parsers/metadata_parser_filebase_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/performance_monitor/performance_monitor_browsertest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/predictors/predictor_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/file_path_verifier_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/prefix_set.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/prefix_set_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_file.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sessions/session_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/network_profile_bubble.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/tools/validate_installation_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/logging_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/logging_installer_unittest.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome_frame/test/perf/chrome_frame_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/breakpad/browser/crash_dump_manager_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_file_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/mhtml_generation_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/obfuscated_file_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/net/sqlite_persistent_cookie_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tracing/tracing_controller_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/mac/font_loader.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/common/plugin_list_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_audio_processor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_audio_device_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/test/image_decoder_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/weburl_loader_mock_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M courgette/courgette_tool.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/container_names_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/test_data_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/yuv_convert_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/file_stream_unittest.cc View 24 chunks +28 lines, -28 lines 0 comments Download
M net/base/upload_file_element_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/dns_hosts.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_unittest.cc View 15 chunks +15 lines, -15 lines 0 comments Download
M printing/emf_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sql/connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M sql/test/test_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/leveldatabase/env_chromium.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/database/database_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/database/vfs_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/dump_file_system.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/quota/open_file_handle_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/quota/quota_reservation_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
TBR=viettrungluu
7 years ago (2013-12-03 21:07:29 UTC) #1
viettrungluu
LGTM w/nits. https://codereview.chromium.org/102873002/diff/1/base/file_util_unittest.cc File base/file_util_unittest.cc (right): https://codereview.chromium.org/102873002/diff/1/base/file_util_unittest.cc#newcode2318 base/file_util_unittest.cc:2318: base::GetFileSize(image_file, &image_size); Aren't we already in the ...
7 years ago (2013-12-03 21:20:18 UTC) #2
brettw
7 years ago (2013-12-04 18:22:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r238722.

Powered by Google App Engine
This is Rietveld 408576698