Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Unified Diff: chrome/browser/extensions/sandboxed_unpacker.cc

Issue 102873002: Move GetFileSize, NormalizeFilePath to base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/sandboxed_unpacker.cc
diff --git a/chrome/browser/extensions/sandboxed_unpacker.cc b/chrome/browser/extensions/sandboxed_unpacker.cc
index 8fd15efdf718d1ebb668ceee540864057f437b7a..48c9230fc970418dfca22ace526f4fda3deea84c 100644
--- a/chrome/browser/extensions/sandboxed_unpacker.cc
+++ b/chrome/browser/extensions/sandboxed_unpacker.cc
@@ -72,7 +72,7 @@ void RecordSuccessfulUnpackTimeHistograms(
// To get a sense of how CRX size impacts unpack time, record unpack
// time for several increments of CRX size.
int64 crx_file_size;
- if (!file_util::GetFileSize(crx_path, &crx_file_size)) {
+ if (!base::GetFileSize(crx_path, &crx_file_size)) {
UMA_HISTOGRAM_COUNTS("Extensions.SandboxUnpackSuccessCantGetCrxSize", 1);
return;
}
@@ -135,8 +135,7 @@ bool VerifyJunctionFreeLocation(base::FilePath* temp_dir) {
return false;
base::FilePath normalized_temp_file;
- bool normalized =
- file_util::NormalizeFilePath(temp_file, &normalized_temp_file);
+ bool normalized = base::NormalizeFilePath(temp_file, &normalized_temp_file);
if (!normalized) {
// If |temp_file| contains a link, the sandbox will block al file system
// operations, and the install will fail.
@@ -293,7 +292,7 @@ void SandboxedUnpacker::Start() {
// will cause file system access outside the sandbox path, and the sandbox
// will deny the operation.
base::FilePath link_free_crx_path;
- if (!file_util::NormalizeFilePath(temp_crx_path, &link_free_crx_path)) {
+ if (!base::NormalizeFilePath(temp_crx_path, &link_free_crx_path)) {
LOG(ERROR) << "Could not get the normalized path of "
<< temp_crx_path.value();
ReportFailure(
« no previous file with comments | « chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc ('k') | chrome/browser/history/history_database.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698