Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: chrome/installer/util/logging_installer_unittest.cc

Issue 102873002: Move GetFileSize, NormalizeFilePath to base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/logging_installer.cc ('k') | chrome_frame/test/perf/chrome_frame_perftest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/logging_installer_unittest.cc
diff --git a/chrome/installer/util/logging_installer_unittest.cc b/chrome/installer/util/logging_installer_unittest.cc
index c605be691e41c1dfb86d0610d8799882089aee12..7bc1c4532ff1916a1f9058f3d4259a5947db906c 100644
--- a/chrome/installer/util/logging_installer_unittest.cc
+++ b/chrome/installer/util/logging_installer_unittest.cc
@@ -24,13 +24,13 @@ TEST(LoggingInstallerTest, TestTruncate) {
ASSERT_TRUE(base::PathExists(temp_file));
int64 file_size = 0;
- EXPECT_TRUE(file_util::GetFileSize(temp_file, &file_size));
+ EXPECT_TRUE(base::GetFileSize(temp_file, &file_size));
EXPECT_EQ(test_data.size(), file_size);
EXPECT_EQ(installer::LOGFILE_TRUNCATED,
installer::TruncateLogFileIfNeeded(temp_file));
- EXPECT_TRUE(file_util::GetFileSize(temp_file, &file_size));
+ EXPECT_TRUE(base::GetFileSize(temp_file, &file_size));
EXPECT_EQ(installer::kTruncatedInstallerLogFileSize , file_size);
// Check that the temporary file was deleted.
@@ -49,13 +49,13 @@ TEST(LoggingInstallerTest, TestTruncationNotNeeded) {
ASSERT_TRUE(base::PathExists(temp_file));
int64 file_size = 0;
- EXPECT_TRUE(file_util::GetFileSize(temp_file, &file_size));
+ EXPECT_TRUE(base::GetFileSize(temp_file, &file_size));
EXPECT_EQ(test_data.size(), file_size);
EXPECT_EQ(installer::LOGFILE_UNTOUCHED,
installer::TruncateLogFileIfNeeded(temp_file));
EXPECT_TRUE(base::PathExists(temp_file));
- EXPECT_TRUE(file_util::GetFileSize(temp_file, &file_size));
+ EXPECT_TRUE(base::GetFileSize(temp_file, &file_size));
EXPECT_EQ(test_data.size(), file_size);
}
@@ -70,7 +70,7 @@ TEST(LoggingInstallerTest, TestInUseNeedsTruncation) {
file_util::WriteFile(temp_file, &test_data[0], test_data.size()));
ASSERT_TRUE(base::PathExists(temp_file));
int64 file_size = 0;
- EXPECT_TRUE(file_util::GetFileSize(temp_file, &file_size));
+ EXPECT_TRUE(base::GetFileSize(temp_file, &file_size));
EXPECT_EQ(test_data.size(), file_size);
// Prevent the log file from being moved or deleted.
@@ -84,7 +84,7 @@ TEST(LoggingInstallerTest, TestInUseNeedsTruncation) {
EXPECT_EQ(installer::LOGFILE_UNTOUCHED,
installer::TruncateLogFileIfNeeded(temp_file));
EXPECT_TRUE(base::PathExists(temp_file));
- EXPECT_TRUE(file_util::GetFileSize(temp_file, &file_size));
+ EXPECT_TRUE(base::GetFileSize(temp_file, &file_size));
EXPECT_EQ(test_data.size(), file_size);
}
@@ -99,7 +99,7 @@ TEST(LoggingInstallerTest, TestMoveFailsNeedsTruncation) {
file_util::WriteFile(temp_file, &test_data[0], test_data.size()));
ASSERT_TRUE(base::PathExists(temp_file));
int64 file_size = 0;
- EXPECT_TRUE(file_util::GetFileSize(temp_file, &file_size));
+ EXPECT_TRUE(base::GetFileSize(temp_file, &file_size));
EXPECT_EQ(test_data.size(), file_size);
// Create an inconvenient, non-deletable file in the location that
« no previous file with comments | « chrome/installer/util/logging_installer.cc ('k') | chrome_frame/test/perf/chrome_frame_perftest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698