Processing USERNAME reply from Autofill server in Password Manager

components/autofill/core/browser/field_types.h

Index: components/autofill/core/browser/field_types.h
diff --git a/components/autofill/core/browser/field_types.h b/components/autofill/core/browser/field_types.h
index c24462ac40f5ba7f65021a342a33fabe287916b9..90f27acff07e9922e779c86f8c603c1c9db9aa0c 100644
--- a/components/autofill/core/browser/field_types.h
+++ b/components/autofill/core/browser/field_types.h
@@ -140,10 +140,14 @@ enum ServerFieldType {
   // a previous upload of ACCOUNT_CREATION_PASSWORD was incorrect.
   NOT_ACCOUNT_CREATION_PASSWORD = 85,
 
+  // Field types for username fields in password forms.
+  USERNAME = 86,
+  USERNAME_AND_EMAIL_ADDRESS = 87,
+
   // No new types can be added without a corresponding change to the Autofill
   // server.
 
-  MAX_VALID_FIELD_TYPE = 86,
+  MAX_VALID_FIELD_TYPE = 88,
 };
 
 // The list of all HTML autocomplete field type hints supported by Chrome.
@@ -231,6 +235,7 @@ enum FieldTypeGroup {
   CREDIT_CARD,
   PASSWORD_FIELD,
   TRANSACTION,
+  USERNAME_FIELD,

[Ilya Sherman, 2015/03/26 00:30:04]

nit: "Field" seems redundant.

[dvadym, 2015/03/26 12:29:13]

I did it to be consistent with PASSWORD_FIELD. And after changing to USERNAME, I
realized why I can't name it USERNAME: in enum ServerFieldType it's already
defined element USERNAME. So it seems USERNAME_FIELD is ok name for this item.
What do you think?

[Ilya Sherman, 2015/03/31 00:45:04]

Ah, fair enough.  Okay :)

 };
 
 typedef std::set<ServerFieldType> ServerFieldTypeSet;