Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1685)

Unified Diff: components/autofill/core/common/password_form.cc

Issue 1028163002: Processing USERNAME reply from Autofill server in Password Manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed many reviewer comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/common/password_form.cc
diff --git a/components/autofill/core/common/password_form.cc b/components/autofill/core/common/password_form.cc
index 066899e943b5a7bdc0e29c105b10933baeaa181f..dbae96d0f54d987cfd446bc657c3ea841c71ca39 100644
--- a/components/autofill/core/common/password_form.cc
+++ b/components/autofill/core/common/password_form.cc
@@ -21,7 +21,8 @@ PasswordForm::PasswordForm()
type(TYPE_MANUAL),
times_used(0),
generation_upload_status(NO_SIGNAL_SENT),
- skip_zero_click(false) {
+ skip_zero_click(false),
+ parsed_using_autofill_predictions(false) {
}
PasswordForm::~PasswordForm() {
@@ -59,7 +60,9 @@ bool PasswordForm::operator==(const PasswordForm& form) const {
display_name == form.display_name &&
avatar_url == form.avatar_url &&
federation_url == form.federation_url &&
- skip_zero_click == form.skip_zero_click;
+ skip_zero_click == form.skip_zero_click &&
+ parsed_using_autofill_predictions ==
+ form.parsed_using_autofill_predictions;
}
bool PasswordForm::operator!=(const PasswordForm& form) const {
@@ -97,7 +100,9 @@ std::ostream& operator<<(std::ostream& os, const PasswordForm& form) {
<< " display_name: " << base::UTF16ToUTF8(form.display_name)
<< " avatar_url: " << form.avatar_url
<< " federation_url: " << form.federation_url
- << " skip_next_zero_click: " << form.skip_zero_click;
+ << " skip_next_zero_click: " << form.skip_zero_click
+ << " parsed_using_autofill_predictions:"
Ilya Sherman 2015/03/26 00:30:04 nit: Please add a space after the colon.
dvadym 2015/03/26 12:29:13 Done.
+ << form.parsed_using_autofill_predictions;
}
} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698