components/autofill/core/browser/autofill_metrics.cc - Issue 1028163002: Processing USERNAME reply from Autofill server in Password Manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_metrics.cc

Issue 1028163002: Processing USERNAME reply from Autofill server in Password Manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed many reviewer comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_form_conversion_utils.cc ('K') | « components/autofill/core/browser/autofill_manager.cc ('k') | components/autofill/core/browser/autofill_profile.cc » ('j') | components/autofill/core/browser/field_types.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_metrics.cc

diff --git a/components/autofill/core/browser/autofill_metrics.cc b/components/autofill/core/browser/autofill_metrics.cc

index c016c6bcec3fc8141e2b67afeef17c01edbba3f4..f06f333fe4abd47c4118c073de9903aef79d4e48 100644

--- a/components/autofill/core/browser/autofill_metrics.cc

+++ b/components/autofill/core/browser/autofill_metrics.cc

@@ -35,6 +35,7 @@ enum FieldTypeGroupForMetrics {

GROUP_CREDIT_CARD_TYPE,

GROUP_PASSWORD,

GROUP_ADDRESS_LINE_3,

+ GROUP_USERNAME,

Ilya Sherman 2015/03/26 00:30:04 Please update histograms.xml for this change.

dvadym 2015/03/26 12:29:13 I've added in one place in histograms.xml about us

Ilya Sherman 2015/03/31 00:45:04 Yes, thanks :)

NUM_FIELD_TYPE_GROUPS_FOR_METRICS

};

@@ -153,6 +154,10 @@ int GetFieldTypeGroupMetric(ServerFieldType field_type,

group = GROUP_PASSWORD;

break;

+ case USERNAME_FIELD:

+ group = GROUP_USERNAME;

+ break;

case TRANSACTION:

NOTREACHED();

break;